You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/25 00:25:53 UTC
[GitHub] [spark] HyukjinKwon removed a comment on pull request #31303: [SPARK-34211][SQL][TESTS] Benchmark TPC-DS with 1GB scale factor
HyukjinKwon removed a comment on pull request #31303:
URL: https://github.com/apache/spark/pull/31303#issuecomment-766461497
If I remember correctly, the purpose of banning GitHub Actions and 3rd part repository was to avoid running unreviewed codes (https://github.com/apache/spark/pull/31104#discussion_r554498229), and we enabled it by setting a specific commit that was reviewed. The specific repo used in this PR has been developed and reviewed by multiple Spark committers too.
Yeah, it would be great if we can tell if the perf diff is considerably big, @wangyum. If it's too big, it will be less making sense to add.
BTW, I believe it's not a security problem of using docker images from your repo because you're also a reliable ASF Spark PMC, and the changes there have been reviewed by me too. I would take this just as a maintenance problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org