[GitHub] [submarine] liuxunorg commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #209: SUBMARINE-410. Supplement submarine artifactId in pom.xml
URL: https://github.com/apache/submarine/pull/209#discussion_r389456330
 
 

 ##########
 File path: submarine-server/server-rpc/src/main/java/org/apache/submarine/server/rpc/SubmarineRpcServer.java
 ##########
 @@ -225,7 +224,7 @@ private ApplicationIdProto checkFeature(ParametersHolderProto request) {
 
     protected ApplicationId run(ClientContext clientContext, Parameter parameter)
         throws IOException, YarnException, SubmarineException {
-      // TODO replaced with JobManager
+      // TODO(who) replaced with JobManager
 
 Review comment:
   beacuse todo must specify who to complete.
   https://github.com/apache/submarine/blob/master/dev-support/maven-config/checkstyle.xml#L42

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org