You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/04/15 19:41:56 UTC
Review Request 33231: Views : create example view for Cluster
Association and Auto Create
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33231/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-10504
https://issues.apache.org/jira/browse/AMBARI-10504
Repository: ambari
Description
-------
Create an example view under ambari-views/examples that demonstrates Cluster Association and Auto Create.
Diffs
-----
ambari-views/examples/cluster-view/docs/index.md PRE-CREATION
ambari-views/examples/cluster-view/pom.xml PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigurationService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/PropertyService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/SettingService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/resources/ui/index.html PRE-CREATION
ambari-views/examples/cluster-view/src/main/resources/view.xml PRE-CREATION
ambari-views/examples/pom.xml 5bc4fb5
Diff: https://reviews.apache.org/r/33231/diff/
Testing
-------
Manual test of example.
All unit tests pass for ambari-views and examples including schema validation for example view.xml
Thanks,
Tom Beerbower
Re: Review Request 33231: Views : create example view for Cluster
Association and Auto Create
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33231/#review80254
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 15, 2015, 3:11 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33231/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 3:11 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-10504
> https://issues.apache.org/jira/browse/AMBARI-10504
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create an example view under ambari-views/examples that demonstrates Cluster Association and Auto Create.
>
>
> Diffs
> -----
>
> ambari-views/examples/cluster-view/docs/index.md PRE-CREATION
> ambari-views/examples/cluster-view/pom.xml PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigServlet.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigurationService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/PropertyService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/SettingService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/WEB-INF/web.xml PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/view.xml PRE-CREATION
> ambari-views/examples/pom.xml 5bc4fb5
>
> Diff: https://reviews.apache.org/r/33231/diff/
>
>
> Testing
> -------
>
> Manual test of example.
>
> All unit tests pass for ambari-views and examples including schema validation for example view.xml
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 33231: Views : create example view for Cluster
Association and Auto Create
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33231/
-----------------------------------------------------------
(Updated April 15, 2015, 7:11 p.m.)
Review request for Ambari and Nate Cole.
Changes
-------
update patch
Bugs: AMBARI-10504
https://issues.apache.org/jira/browse/AMBARI-10504
Repository: ambari
Description
-------
Create an example view under ambari-views/examples that demonstrates Cluster Association and Auto Create.
Diffs (updated)
-----
ambari-views/examples/cluster-view/docs/index.md PRE-CREATION
ambari-views/examples/cluster-view/pom.xml PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigServlet.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigurationService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/PropertyService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/SettingService.java PRE-CREATION
ambari-views/examples/cluster-view/src/main/resources/WEB-INF/web.xml PRE-CREATION
ambari-views/examples/cluster-view/src/main/resources/view.xml PRE-CREATION
ambari-views/examples/pom.xml 5bc4fb5
Diff: https://reviews.apache.org/r/33231/diff/
Testing
-------
Manual test of example.
All unit tests pass for ambari-views and examples including schema validation for example view.xml
Thanks,
Tom Beerbower
Re: Review Request 33231: Views : create example view for Cluster
Association and Auto Create
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On April 15, 2015, 6:09 p.m., Nate Cole wrote:
> >
Thanks for the review!
I dropped the index.html and replaced it with a simple Servlet and web.xml.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33231/#review80229
-----------------------------------------------------------
On April 15, 2015, 7:11 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33231/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 7:11 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-10504
> https://issues.apache.org/jira/browse/AMBARI-10504
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create an example view under ambari-views/examples that demonstrates Cluster Association and Auto Create.
>
>
> Diffs
> -----
>
> ambari-views/examples/cluster-view/docs/index.md PRE-CREATION
> ambari-views/examples/cluster-view/pom.xml PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigServlet.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigurationService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/PropertyService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/SettingService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/WEB-INF/web.xml PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/view.xml PRE-CREATION
> ambari-views/examples/pom.xml 5bc4fb5
>
> Diff: https://reviews.apache.org/r/33231/diff/
>
>
> Testing
> -------
>
> Manual test of example.
>
> All unit tests pass for ambari-views and examples including schema validation for example view.xml
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 33231: Views : create example view for Cluster
Association and Auto Create
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33231/#review80229
-----------------------------------------------------------
Ship it!
ambari-views/examples/cluster-view/src/main/resources/ui/index.html
<https://reviews.apache.org/r/33231/#comment130025>
2 space indents?
ambari-views/examples/cluster-view/src/main/resources/ui/index.html
<https://reviews.apache.org/r/33231/#comment130024>
Nit: what will happen if this script href gets removed by jquery? Should it get included with the view?
- Nate Cole
On April 15, 2015, 1:41 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33231/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 1:41 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-10504
> https://issues.apache.org/jira/browse/AMBARI-10504
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create an example view under ambari-views/examples that demonstrates Cluster Association and Auto Create.
>
>
> Diffs
> -----
>
> ambari-views/examples/cluster-view/docs/index.md PRE-CREATION
> ambari-views/examples/cluster-view/pom.xml PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/ClusterConfigurationService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/PropertyService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/java/org/apache/ambari/view/cluster/SettingService.java PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/ui/index.html PRE-CREATION
> ambari-views/examples/cluster-view/src/main/resources/view.xml PRE-CREATION
> ambari-views/examples/pom.xml 5bc4fb5
>
> Diff: https://reviews.apache.org/r/33231/diff/
>
>
> Testing
> -------
>
> Manual test of example.
>
> All unit tests pass for ambari-views and examples including schema validation for example view.xml
>
>
> Thanks,
>
> Tom Beerbower
>
>