You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/20 01:57:34 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage

yaooqinn commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r1000069902


##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
             <version>${project.version}</version>
         </dependency>
 
+        <dependency>

Review Comment:
   Can we just make the full functionality on the plugin side? IMHO, it is not necessary to include a dependency based on my experience to create more than one plugins 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org