You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/02/01 08:54:00 UTC
[jira] [Commented] (QPID-8666) [Broker-J] Broker plugin jdbc-provider-bone replacement
[ https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813111#comment-17813111 ]
ASF GitHub Bot commented on QPID-8666:
--------------------------------------
dakirily commented on code in PR #235:
URL: https://github.com/apache/qpid-broker-j/pull/235#discussion_r1474043869
##########
broker-core/src/main/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecoverer.java:
##########
@@ -805,11 +805,10 @@ private static class VirtualHostEntryUpgrader
addAttributeTransformer("jdbcBytesForBlob", addContextVar("qpid.jdbcstore.useBytesForBlob")).
addAttributeTransformer("jdbcBlobType", addContextVar("qpid.jdbcstore.blobType")).
addAttributeTransformer("jdbcVarbinaryType", addContextVar("qpid.jdbcstore.varBinaryType")).
- addAttributeTransformer("partitionCount", addContextVar("qpid.jdbcstore.bonecp.partitionCount")).
- addAttributeTransformer("maxConnectionsPerPartition",
- addContextVar("qpid.jdbcstore.bonecp.maxConnectionsPerPartition")).
- addAttributeTransformer("minConnectionsPerPartition",
- addContextVar("qpid.jdbcstore.bonecp.minConnectionsPerPartition")),
+ addAttributeTransformer("maximumPoolSize",
+ addContextVar("qpid.jdbcstore.hikaricp.maximumPoolSize")).
+ addAttributeTransformer("minimumIdle",
+ addContextVar("qpid.jdbcstore.hikaricp.minimumIdle")),
Review Comment:
Hi Robbie,
Thank you for the review. You're right, that needs to be fixed.
Are there any conventions regarding the model version change? It seems to me that as only the context attribute names / values were changed without adding new entities or attributes, model version could be changed from 9.0 to 9.1? Or should the model version match the broker version as well? E.g. model version 9.2 for broker version 9.2.0 until other model change or if model changes to 10 then qpid-broker-j version have to be changed 10.0.0 as well?
> [Broker-J] Broker plugin jdbc-provider-bone replacement
> -------------------------------------------------------
>
> Key: QPID-8666
> URL: https://issues.apache.org/jira/browse/QPID-8666
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-9.1.0
> Reporter: Daniil Kirilyuk
> Priority: Major
> Fix For: qpid-java-broker-9.2.0
>
>
> Broker plugin jdbc-provider-bone relies on JDBC connection pooling library bonecp, which is no longer developed or updated. The [github project page|https://github.com/wwadge/bonecp] states:
> "BoneCP is a Java JDBC connection pool implementation that is tuned for high performance by minimizing lock contention to give greater throughput for your applications. It beats older connection pools such as C3P0 and DBCP but should now be considered deprecated in favour of HikariCP".
> Plugin jdbc-provider-bone should be replaced with the new one jdbc-provider-hikaricp based on [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both libraries use Apache-2.0 license.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org