You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/03/15 06:27:51 UTC
[GitHub] incubator-weex pull request #108: update doc example about component rect
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/108
update doc example about component rect
1. update doc example about component rect
2. remove unused zip file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit a99b6842080f353f6e50eb8c733890ddf40ae589
Author: acton393 <zh...@gmail.com>
Date: 2017-03-15T06:25:54Z
* [ios] update doc example about getcomponentRect
commit 22bf16e297369d4bcee5b910adec9981a2102b68
Author: acton393 <zh...@gmail.com>
Date: 2017-03-15T06:26:25Z
* [ios] remove unused zip file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #108: update doc example about component rect
Posted by Jinjiang <gi...@git.apache.org>.
Github user Jinjiang commented on the issue:
https://github.com/apache/incubator-weex/pull/108
Why a file named `WeexDemo.app.zip` added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #108: update doc example about component rect
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 closed the pull request at:
https://github.com/apache/incubator-weex/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #108: update doc example about component rect
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/108
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
1 Error
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/acton393/incubator-weex/blob/67a157089e5decc106d544a8d0133e9f6b1697a9/ios/sdk/WeexSDK/Sources/Utility/WXBoxShadow.m#L34">ios/sdk/WeexSDK/Sources/Utility/WXBoxShadow.m#L34</a></strong>: writable atomic property \u2018shadowColor\u2019 cannot pair a synthesized getter with a user defined setter [-Werror,-Watomic-property-with-user-defined-accessor] <br />```</p>
<ul>
<li>(void)setShadowColor: (CGColorRef)shadowColor<br />
```</li>
<</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #108: update doc example about component rect
Posted by Jinjiang <gi...@git.apache.org>.
Github user Jinjiang commented on the issue:
https://github.com/apache/incubator-weex/pull/108
Squash merged (in order to avoid the large file in the repo & history).
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #108: update doc example about component rect
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/108
The `WeexDemo.app.zip` is for ci test before, now it is useless, so remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #108: update doc example about component rect
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/108
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
4 Errors
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/acton393/incubator-weex/blob/6519c4bf3dc2f1d8447742cc347a76b6e9b60017/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018NSNumber *\u2019 to parameter of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
[_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/acton393/incubator-weex/blob/6519c4bf3dc2f1d8447742cc347a76b6e9b60017/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
[_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/acton393/incubator-weex/blob/6519c4bf3dc2f1d8447742cc347a76b6e9b60017/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
NSNumber *index = [_headerToIndexTable objectForKey:header];
</code></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong><a href="https://github.com/acton393/incubator-weex/blob/6519c4bf3dc2f1d8447742cc347a76b6e9b60017/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types initializing \u2018NSNumber *\u2019 with an expression of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types] <br /><code>
NSNumber *index = [_headerToIndexTable objectForKey:header];
</code></td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---