Re: [PR] GUACAMOLE-2185: Port numbers should be validated by guacd. [guacamole-server]

["necouchman (via GitHub)" <gi...@apache.org>]

necouchman commented on code in PR #627:
URL: https://github.com/apache/guacamole-server/pull/627#discussion_r2725895934


##########
src/libguac/guacamole/string.h:
##########
@@ -26,9 +26,39 @@
  * @file string.h
  */
 
+#include <limits.h>
 #include <stddef.h>
 #include <string.h>
 
+/**
+ *  String buffer size needed to represent 'int', and 'unsigned short'in decimal

Review Comment:
   Missing space here after `'unsigned short'`.



##########
src/libguac/guacamole/wol-constants.h:
##########
@@ -20,6 +20,8 @@
 #ifndef GUAC_WOL_CONSTANTS_H
 #define GUAC_WOL_CONSTANTS_H
 
+#include "guacamole/string.h"
+

Review Comment:
   I think this should be included in `string.c` instead of here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org