You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by emilianbold <gi...@git.apache.org> on 2017/07/16 21:24:55 UTC
[GitHub] jmeter pull request #299: Mavenization
GitHub user emilianbold opened a pull request:
https://github.com/apache/jmeter/pull/299
Mavenization
I'm starting this pull request to get some feedback on the current changes.
Adding a Maven-based build system for JMeter implies moving and renaming some files and it would be best if we discuss this before I go too deep with customisations.
If you look at my commits, excluding the last one 'Add pom.xml files', they just rearrange files and update the changes in build.xml.
So, the plan is to still use ant, except on a Maven friendly file layout.
Note how I haven't moved the sources under src/main/java like Maven expects. I'm loading the sources from ./ but I would also like to move them. Each module (src/components, src/core, etc.) would get its own folder (src/components/src/main/java, src/core/src/main/java, etc).
As I've mentioned on the mailing list, I would also prefer to have all the modules at the same level. This means moving all the protocol/ftp, protocol/http modules a folder up, next to core and components/.
I'm able to load JMeter under Apache NetBeans and IntelliJ IDEA with the new Maven config so I am pleased with this as this is what was bothering me.
Replacing ant altogether is a big step but if we do it incrementally like I'm showing here by just preparing the file layout, etc. we can do it with less friction.
build.xml is 3600 lines long and can't easily be replaced all at once. I can imagine a transition period where ant will still be used for many targets, perhaps via the maven-antrun-plugin Maven plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emilianbold/jmeter emilianbold-mavenization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit 085dbe25ce9957095577079dd6f5846b6a044c0e
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-08T06:35:22Z
Move resources to src/main/resources
commit 22f43bbfd4798ca2435b749217ee2b417fed7111
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-09T16:30:51Z
Load resources from src/main/resources in build.xml
commit 9e55baac85a478b7ccd57ffb8152036788c95616
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-10T21:11:58Z
Move launcher to dedicated folder
commit 2468c2b5a9ca0bf740a3f1458436adff6240848e
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-10T21:17:59Z
Avoid cyclic dependency in ShutdownClient
commit 849db7464435122717d452d16f6acf033a3fa67a
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-10T22:05:04Z
Build the launcher from the new folder
commit e498c8233c8cb9f9d90af98378ff0e01178a7295
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-11T08:48:41Z
Add pom.xml files
commit c3c4c7fe3cb3674620e8247a5690ccf832b0aa49
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-11T13:53:23Z
Move bshclient to dedicated folder
commit ee90e0de95fc934bd69c01aea024b04e75e60437
Author: Emilian Bold <em...@apache.org>
Date: 2017-07-16T20:27:19Z
Rename default.notice to plain NOTICE and default.license to LICENSE to make it easy on Maven
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #299: Mavenization
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold closed the pull request at:
https://github.com/apache/jmeter/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #299: Mavenization
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/jmeter/pull/299
> I think we should wait for 3.3 release , don't you think so ?
I have checked to JARs to be identical so moving some files around while preserving the output seems safe.
Still, 3.3 is close, so it makes sense to have a code freeze.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #299: Mavenization
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/299
Thanks for your work. I have just had a glance and will look into it as soon as I have a bit more time.
But I like the general direction, especially that we can (hopefully) migrate from ant to maven in small steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #299: Mavenization
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/jmeter/pull/299
Any update on this? Most of the steps, like "Move resources to src/main/resources" are quite harmless and could be done at any time.
It's complicated to work on different branches when I have Maven only on one of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #299: Mavenization
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/299
Hello @emilianbold ,
I think we should wait for 3.3 release , don't you think so ?
Regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---