You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/03/13 17:57:28 UTC

[GitHub] flink pull request #5685: [FLINK-7521][flip6] Remove the 10MB limit from the...

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5685#discussion_r174225988
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FlinkHttpObjectAggregator.java ---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest;
    +
    +import org.apache.flink.configuration.RestOptions;
    +import org.apache.flink.runtime.rest.handler.util.HandlerUtils;
    +import org.apache.flink.runtime.rest.messages.ErrorResponseBody;
    +
    +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext;
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.TooLongFrameException;
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpObject;
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * Same as {@link org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpObjectDecoder}
    + * but returns HTTP 413 to the client if the payload exceeds {@link #maxContentLength}.
    + */
    +public class FlinkHttpObjectAggregator extends org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpObjectAggregator {
    +
    +	private final Map<String, String> responseHeaders;
    +
    +	public FlinkHttpObjectAggregator(final int maxContentLength, final Map<String, String> responseHeaders) {
    +		super(maxContentLength);
    +		this.responseHeaders = responseHeaders;
    --- End diff --
    
    `checkNotNull` or `@NonNull` missing


---