You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2024/07/30 21:44:04 UTC
[PR] API: Update Conversions.fromPartitionString API to handle timestamps [iceberg]
amogh-jahagirdar opened a new pull request, #10820:
URL: https://github.com/apache/iceberg/pull/10820
This can be considered as an alternative to https://github.com/apache/iceberg/pull/10724
In #10724, a new API on the DataFile builder was proposed which enabled callers to pass in custom partition string conversion functions. The rationale behind that API was that Iceberg should not be opinionated on how to do the conversion, and `Conversions` utility primarily existed for enabling Hive style table migrations. Callers could pass in whatever they wanted.
The use case that was driving #10724 was to enable Delta uniform to be be able to have timestamp partitions.
Since the `Conversions` utility already doesn't support timestamps, and maybe the proposed API isn't really needed beyond the uniform use-case, this approach just adds the handling the timestamp partitioning.
Specifically, handling expects an ISO8601 UTC adjusted instant. Anything else will fail parsing in the conversion. The conversion logic for timestamp returns a microseconds since epoch long that aligns with what the Iceberg data type representation is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Update Conversions.fromPartitionString API to handle timestamps [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10820:
URL: https://github.com/apache/iceberg/pull/10820#issuecomment-2480862673
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Update Conversions.fromPartitionString API to handle timestamps [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10820: API: Update Conversions.fromPartitionString API to handle timestamps
URL: https://github.com/apache/iceberg/pull/10820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Update Conversions.fromPartitionString API to handle timestamps [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #10820:
URL: https://github.com/apache/iceberg/pull/10820#issuecomment-2261590336
I think there's a [better solution](https://github.com/apache/iceberg/pull/10724#issuecomment-2261582583) that I wrote up on the other issue. I don't think it is a good idea to add capabilities like this (that will only grow more complex) when we want people to pass values directly and parse partition strings using the same library that produced those partition strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Update Conversions.fromPartitionString API to handle timestamps [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10820:
URL: https://github.com/apache/iceberg/pull/10820#issuecomment-2466519773
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org