[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

[GitBox <gi...@apache.org>]

mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object
URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378307498
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/api/shared_handlers.go
 ##########
 @@ -367,34 +369,123 @@ func CreateHandler(creator Creator) http.HandlerFunc {
 		obj := reflect.New(objectType).Interface().(Creator)
 		obj.SetInfo(inf)
 
-		err := decodeAndValidateRequestBody(r, obj)
-		if err != nil {
-			HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, err, nil)
-			return
-		}
+		if c, ok := obj.(AllowMultipleCreates); ok && c.AllowMultipleCreates() {
+			data, err := ioutil.ReadAll(r.Body)
+			if err != nil {
+				HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, err, nil)
+				return
+			}
 
-		if t, ok := obj.(Tenantable); ok {
-			authorized, err := t.IsTenantAuthorized(inf.User)
+			objSlice, err := parseMultipleCreates(data, objectType, inf)
 			if err != nil {
-				HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("checking tenant authorized: "+err.Error()))
+				HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, err)
 				return
 			}
-			if !authorized {
-				HandleErr(w, r, inf.Tx.Tx, http.StatusForbidden, errors.New("not authorized on this tenant"), nil)
+
+			for _, objElemInt := range objSlice {
+				objElem := reflect.ValueOf(objElemInt).Interface().(Creator)
+
+				err = objElem.Validate()
+				if err != nil {
+					HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, err, nil)
+					return
+				}
+
+				if t, ok := objElem.(Tenantable); ok {
+					authorized, err := t.IsTenantAuthorized(inf.User)
+					if err != nil {
+						HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("checking tenant authorized: "+err.Error()))
+						return
+					}
+					if !authorized {
+						HandleErr(w, r, inf.Tx.Tx, http.StatusForbidden, errors.New("not authorized on this tenant"), nil)
+						return
+					}
+				}
+
+				userErr, sysErr, errCode = objElem.Create()
+				if userErr != nil || sysErr != nil {
+					HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+					return
+				}
+
+				if err = CreateChangeLog(ApiChange, Created, objElem, inf.User, inf.Tx.Tx); err != nil {
+					HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, tc.DBError, errors.New("inserting changelog: "+err.Error()))
+					return
+				}
+			}
+			if len(objSlice) == 1 {
+				WriteRespAlertObj(w, r, tc.SuccessLevel, objSlice[0].GetType()+" was created.", objSlice[0])
+			} else {
+				WriteRespAlertObj(w, r, tc.SuccessLevel, objSlice[0].GetType()+"s were created.", objSlice)
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services