You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/05/16 02:23:40 UTC
Review Request 34301: Implementing benchmark for snapshot restore.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-1321
https://issues.apache.org/jira/browse/AURORA-1321
Repository: aurora
Description
-------
Adding a snapshot restore benchmark created during investigating AURORA-1321:
```
Benchmark (updateCount) Mode Cnt Score Error Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
```
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
Diff: https://reviews.apache.org/r/34301/diff/
Testing
-------
./gradlew -Pq build
./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
Thanks,
Maxim Khutornenko
Re: Review Request 34301: Implementing benchmark for snapshot restore.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 16, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > Thanks for doing this. I'd recommend marking this as fixing https://issues.apache.org/jira/browse/AURORA-1318 as well, as this patch obseletes my work there investigating a wild guess about task deepCopy performance.
Thanks, added AURORA-1318.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/#review84008
-----------------------------------------------------------
On May 16, 2015, 1:22 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34301/
> -----------------------------------------------------------
>
> (Updated May 16, 2015, 1:22 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1321
> https://issues.apache.org/jira/browse/AURORA-1321
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a snapshot restore benchmark created during investigating AURORA-1321:
>
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
>
> Diff: https://reviews.apache.org/r/34301/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34301: Implementing benchmark for snapshot restore.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/#review84008
-----------------------------------------------------------
Ship it!
Thanks for doing this. I'd recommend marking this as fixing https://issues.apache.org/jira/browse/AURORA-1318 as well, as this patch obseletes my work there investigating a wild guess about task deepCopy performance.
- Kevin Sweeney
On May 15, 2015, 5:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34301/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 5:23 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1321
> https://issues.apache.org/jira/browse/AURORA-1321
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a snapshot restore benchmark created during investigating AURORA-1321:
>
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
>
> Diff: https://reviews.apache.org/r/34301/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34301: Implementing benchmark for snapshot restore.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/#review84018
-----------------------------------------------------------
Master (07ab0bb) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 16, 2015, 1:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34301/
> -----------------------------------------------------------
>
> (Updated May 16, 2015, 1:25 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1318 and AURORA-1321
> https://issues.apache.org/jira/browse/AURORA-1318
> https://issues.apache.org/jira/browse/AURORA-1321
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a snapshot restore benchmark created during investigating AURORA-1321:
>
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
>
> Diff: https://reviews.apache.org/r/34301/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34301: Implementing benchmark for snapshot restore.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/
-----------------------------------------------------------
(Updated May 16, 2015, 1:25 a.m.)
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-1318 and AURORA-1321
https://issues.apache.org/jira/browse/AURORA-1318
https://issues.apache.org/jira/browse/AURORA-1321
Repository: aurora
Description
-------
Adding a snapshot restore benchmark created during investigating AURORA-1321:
```
Benchmark (updateCount) Mode Cnt Score Error Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
```
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
Diff: https://reviews.apache.org/r/34301/diff/
Testing
-------
./gradlew -Pq build
./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
Thanks,
Maxim Khutornenko
Re: Review Request 34301: Implementing benchmark for snapshot restore.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/
-----------------------------------------------------------
(Updated May 16, 2015, 1:22 a.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Minor style fixes.
Bugs: AURORA-1321
https://issues.apache.org/jira/browse/AURORA-1321
Repository: aurora
Description
-------
Adding a snapshot restore benchmark created during investigating AURORA-1321:
```
Benchmark (updateCount) Mode Cnt Score Error Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 14.678 ± 0.783 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 2.941 ± 0.130 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 1.448 ± 0.069 ops/s
```
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java PRE-CREATION
src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java e52692968ef7323c25782f7f7d1381ae49b38a08
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e3515880303bff28931f396758c9790e79d6758c
Diff: https://reviews.apache.org/r/34301/diff/
Testing
-------
./gradlew -Pq build
./gradlew jmh -Pbenchmarks='SnapshotBenchmarks'
Thanks,
Maxim Khutornenko