You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (Created) (JIRA)" <ji...@apache.org> on 2011/10/25 14:04:32 UTC

[jira] [Created] (DERBY-5479) Don't run MessageVetter unless messages have changed

Don't run MessageVetter unless messages have changed
----------------------------------------------------

                 Key: DERBY-5479
                 URL: https://issues.apache.org/jira/browse/DERBY-5479
             Project: Derby
          Issue Type: Improvement
          Components: Build tools
    Affects Versions: 10.9.0.0
            Reporter: Knut Anders Hatlen
            Assignee: Knut Anders Hatlen
            Priority: Minor


Continuing my series of patches micro-optimizing the build scripts...

MessageVetter is always run as part of the build, also in incremental builds when nothing has changed. Since it needs to go through more than 800 files, it may take a while (just half a second on the fastest machine I tested, so not a big deal, but that's still a significant portion of the total time in an incremental build). We should skip the message check in incremental builds if none of the messages have changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DERBY-5479) Don't run MessageVetter unless messages have changed

Posted by "Knut Anders Hatlen (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-5479.
---------------------------------------

          Resolution: Fixed
       Fix Version/s: 10.9.0.0
    Issue & fix info:   (was: Patch Available)

Thanks, Rick! For now, I think I'll just go for the patch as it is. If too many files in the top-level generated directory becomes a problem, it should be easy enough to clean it up.

Committed revision 1189059.
                
> Don't run MessageVetter unless messages have changed
> ----------------------------------------------------
>
>                 Key: DERBY-5479
>                 URL: https://issues.apache.org/jira/browse/DERBY-5479
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d5479-1a.diff
>
>
> Continuing my series of patches micro-optimizing the build scripts...
> MessageVetter is always run as part of the build, also in incremental builds when nothing has changed. Since it needs to go through more than 800 files, it may take a while (just half a second on the fastest machine I tested, so not a big deal, but that's still a significant portion of the total time in an incremental build). We should skip the message check in incremental builds if none of the messages have changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (DERBY-5479) Don't run MessageVetter unless messages have changed

Posted by "Knut Anders Hatlen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5479:
--------------------------------------

    Attachment: d5479-1a.diff

Attaching a patch which makes the checkmessages target touch the file generated/checkmessages.done when it's done, and adds logic to skip the target if all the message files are older than generated/checkmessages.done.

(Is the "generated" dir the right place to put such a file? Or should we have a new "generated/timestamps" directory to avoid cluttering the root of the generated dir?)
                
> Don't run MessageVetter unless messages have changed
> ----------------------------------------------------
>
>                 Key: DERBY-5479
>                 URL: https://issues.apache.org/jira/browse/DERBY-5479
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5479-1a.diff
>
>
> Continuing my series of patches micro-optimizing the build scripts...
> MessageVetter is always run as part of the build, also in incremental builds when nothing has changed. Since it needs to go through more than 800 files, it may take a while (just half a second on the fastest machine I tested, so not a big deal, but that's still a significant portion of the total time in an incremental build). We should skip the message check in incremental builds if none of the messages have changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (DERBY-5479) Don't run MessageVetter unless messages have changed

Posted by "Knut Anders Hatlen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5479:
--------------------------------------

    Issue & fix info: Patch Available
    
> Don't run MessageVetter unless messages have changed
> ----------------------------------------------------
>
>                 Key: DERBY-5479
>                 URL: https://issues.apache.org/jira/browse/DERBY-5479
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5479-1a.diff
>
>
> Continuing my series of patches micro-optimizing the build scripts...
> MessageVetter is always run as part of the build, also in incremental builds when nothing has changed. Since it needs to go through more than 800 files, it may take a while (just half a second on the fastest machine I tested, so not a big deal, but that's still a significant portion of the total time in an incremental build). We should skip the message check in incremental builds if none of the messages have changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DERBY-5479) Don't run MessageVetter unless messages have changed

Posted by "Rick Hillegas (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135003#comment-13135003 ] 

Rick Hillegas commented on DERBY-5479:
--------------------------------------

Hi Knut: The patch looks good to me. As long as the file ends up in the generated tree I don't have strong religion about where to put the file. On the one hand, right now the top level generated directory has only subdirectories in it and no ordinary files. On the other hand, we can always move files around if the top level generated directory starts to look cluttered. Thanks.
                
> Don't run MessageVetter unless messages have changed
> ----------------------------------------------------
>
>                 Key: DERBY-5479
>                 URL: https://issues.apache.org/jira/browse/DERBY-5479
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5479-1a.diff
>
>
> Continuing my series of patches micro-optimizing the build scripts...
> MessageVetter is always run as part of the build, also in incremental builds when nothing has changed. Since it needs to go through more than 800 files, it may take a while (just half a second on the fastest machine I tested, so not a big deal, but that's still a significant portion of the total time in an incremental build). We should skip the message check in incremental builds if none of the messages have changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira