You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Christopher Schultz (JIRA)" <de...@velocity.apache.org> on 2007/11/01 19:19:51 UTC
[jira] Created: (VELTOOLS-89) LinkTool's addQueryData method should
automatically add an 'ignore' so addAllParameters will ignore
manually-added query data
LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data
-----------------------------------------------------------------------------------------------------------------------------
Key: VELTOOLS-89
URL: https://issues.apache.org/jira/browse/VELTOOLS-89
Project: Velocity Tools
Issue Type: Improvement
Components: VelocityView
Reporter: Christopher Schultz
Priority: Trivial
Currently, the LinkTool requires that, for each parameter you intend to override from the current request (when using addAllParameters), you do something like this:
$link.addIgnore("foo").addQueryData("foo", "bar").addAllParameters()
It is almost always the case that the "foo" parameter should be ignored from the current request because it's value is being explicitly set by the addQueryData call.
This should be the default behavior, with the current behavior being configurable via the toolbox setup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELTOOLS-89) LinkTool's addQueryData method
should automatically add an 'ignore' so addAllParameters will ignore
manually-added query data
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Bubna resolved VELTOOLS-89.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.0
1.x
1.4
thanks!
> LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: VELTOOLS-89
> URL: https://issues.apache.org/jira/browse/VELTOOLS-89
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Reporter: Christopher Schultz
> Priority: Trivial
> Fix For: 1.4, 1.x, 2.0
>
> Attachments: VELTOOLS-89.diff
>
>
> Currently, the LinkTool requires that, for each parameter you intend to override from the current request (when using addAllParameters), you do something like this:
> $link.addIgnore("foo").addQueryData("foo", "bar").addAllParameters()
> It is almost always the case that the "foo" parameter should be ignored from the current request because it's value is being explicitly set by the addQueryData call.
> This should be the default behavior, with the current behavior being configurable via the toolbox setup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-89) LinkTool's addQueryData method should
automatically add an 'ignore' so addAllParameters will ignore
manually-added query data
Posted by "Christopher Schultz (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christopher Schultz updated VELTOOLS-89:
----------------------------------------
Attachment: VELTOOLS-89.diff
This patch adds to LinkTool:
- Automatic additions of parameter names to ignore list when addQueryData is called (really copyWith)
- Config parameter to enable auto-ignore
- getKey method to QueryPair class
- More unit tests
This patch changes:
- Default is now auto-ignore (was not to auto-ignore with last patch)
- Ignore list is now a Set to prevent duplicates and speed up searches
> LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: VELTOOLS-89
> URL: https://issues.apache.org/jira/browse/VELTOOLS-89
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Reporter: Christopher Schultz
> Priority: Trivial
> Attachments: VELTOOLS-89.diff
>
>
> Currently, the LinkTool requires that, for each parameter you intend to override from the current request (when using addAllParameters), you do something like this:
> $link.addIgnore("foo").addQueryData("foo", "bar").addAllParameters()
> It is almost always the case that the "foo" parameter should be ignored from the current request because it's value is being explicitly set by the addQueryData call.
> This should be the default behavior, with the current behavior being configurable via the toolbox setup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-89) LinkTool's addQueryData method
should automatically add an 'ignore' so addAllParameters will ignore
manually-added query data
Posted by "Christopher Schultz (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539608 ]
Christopher Schultz commented on VELTOOLS-89:
---------------------------------------------
(Patch is relative to the trunk, btw)
> LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: VELTOOLS-89
> URL: https://issues.apache.org/jira/browse/VELTOOLS-89
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Reporter: Christopher Schultz
> Priority: Trivial
> Attachments: VELTOOLS-89.diff
>
>
> Currently, the LinkTool requires that, for each parameter you intend to override from the current request (when using addAllParameters), you do something like this:
> $link.addIgnore("foo").addQueryData("foo", "bar").addAllParameters()
> It is almost always the case that the "foo" parameter should be ignored from the current request because it's value is being explicitly set by the addQueryData call.
> This should be the default behavior, with the current behavior being configurable via the toolbox setup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org