[GitHub] larroy commented on issue #13364: [MXNET-1225] Always use config.mk in make install instructions

[GitBox <gi...@apache.org>]

larroy commented on issue #13364: [MXNET-1225] Always use config.mk in make install instructions
URL: https://github.com/apache/incubator-mxnet/pull/13364#issuecomment-443902882
 
 
   I would suggest to converge in using CMake, I would propose to use a thin wrapper over cmake so we can use a file to define options in this fashion:
   
   https://github.com/apache/incubator-mxnet/blob/master/cmake/cmake_options.yml
   
   This would then work in the same way as config.mk now. But parsed into a commandline as it's done here:
   
   https://github.com/apache/incubator-mxnet/blob/master/dev_menu.py#L48
   
   Also, some of the changes proposed here don't work at all, have they been tested locally?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services