[jira] [Commented] (WICKET-6693) Mark FormComponent#setModelValue(String[]) as not being part of the public API

["Tobias Gierke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900132#comment-16900132 ] 

Tobias Gierke commented on WICKET-6693:
---------------------------------------

I opened a pull request on GitHub: https://github.com/apache/wicket/pull/379

> Mark FormComponent#setModelValue(String[]) as not being part of the public API
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-6693
>                 URL: https://issues.apache.org/jira/browse/WICKET-6693
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 9.0.0-M3
>            Reporter: Tobias Gierke
>            Priority: Trivial
>
> Here's the Jira issue & pull request as mentioned on wicket-dev.
>  
> {quote}Hi, 
>  
> I wasn't even aware of that method . 
>  
> We had that method for ages that way now, but if you care to create a jira issue and pull request, we'll gladly add the internal-use-warning to it. 
>  
> Have fun 
> Sven 
>  
>  
> On 31.07.19 09:27, Tobias Gierke wrote:
> {quote}
> {quote}Hi, 
>  
> While browsing the Wicket source code, a colleague of mine came across this public method.  I wonder what's the use-case for it .. seems it's only getting called from CookieUtils. Maybe it should have a JavaDoc comment stating that it is internal use only ? 
>  
> Cheers, 
> Tobias{quote}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)