[GitHub] [maven] michael-o edited a comment on pull request #674: MNG-7407 Allow core-extension to override default CI-Firendly-Versions handling

[GitBox <gi...@apache.org>]

michael-o edited a comment on pull request #674:
URL: https://github.com/apache/maven/pull/674#issuecomment-1030866814


   > > ```
   > > * Why for Maven 3.8.x only? No master?
   > > ```
   > 
   > I can open a PR for master also.
   
   Yes, please.
   
   > > ```
   > > * The title is misleading. What you actually did is to move a default implementation to a replace component. @cstamas Did this also in resolver. May be can better rewording this to something like: Introduce a ModelVersionProcessor component to make CI Friends Versions pluggable
   > > ```
   > 
   > Sure do you simply want to rename the PR or should I do so?
   
   Yes, please. PR and JIRA issue.
   
   > > ```
   > > * Can this be covered by a test somehow?
   > > ```
   > 
   > There are already some tests for this functionality that also run fine with this changes.
   
   Please point me to them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org