You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2008/12/04 13:27:44 UTC
[jira] Created: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
---------------------------------------------------------------------------------------------------------------
Key: HADOOP-4774
URL: https://issues.apache.org/jira/browse/HADOOP-4774
Project: Hadoop Core
Issue Type: Bug
Components: contrib/capacity-sched
Reporter: Amar Kamat
If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
{code}
Invalid initializater poller interval -1
{code}
I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-4774:
-------------------------------------------
Attachment: HADOOP-4774-3.patch
Attaching file with appropriate changes made.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch, HADOOP-4774-3.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656618#action_12656618 ]
Hadoop QA commented on HADOOP-4774:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12396068/HADOOP-4774-3.patch
against trunk revision 726129.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3745/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3745/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3745/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3745/console
This message is automatically generated.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch, HADOOP-4774-3.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656588#action_12656588 ]
Amar Kamat commented on HADOOP-4774:
------------------------------------
+1.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch, HADOOP-4774-3.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656580#action_12656580 ]
Amar Kamat commented on HADOOP-4774:
------------------------------------
2 minor comments.
- _assertTrue()_ in the catch block is not needed.
- typo : _miliseconds_ should be _milliseconds_.
The main changes look fine to me.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-4774:
-------------------------------------------
Status: Patch Available (was: Open)
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch, HADOOP-4774-3.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653616#action_12653616 ]
Sreekanth Ramakrishnan commented on HADOOP-4774:
------------------------------------------------
attaching results of ant test-patch :
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 5 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
{noformat}
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-4774:
-------------------------------------------
Attachment: HADOOP-4774-2.patch
Attaching patch correcting typo's and incorporating Hemanth's comments.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4774:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to trunk and the Hadoop 0.20 branch. Thanks, Sreekanth !
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.20.0
>
> Attachments: HADOOP-4774-1.patch, HADOOP-4774-2.patch, HADOOP-4774-3.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan reassigned HADOOP-4774:
----------------------------------------------
Assignee: Sreekanth Ramakrishnan
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4774) CapacityScheduler should work even if
capacity-scheduler.xml is not in the classpath i.e with the code defaults
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-4774:
-------------------------------------------
Attachment: HADOOP-4774-1.patch
Attaching the patch fixing this issue.
Added test case to check the values of initialization poller values.
Removed a method from test case which is not being used anywhere.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4774) CapacityScheduler should work even
if capacity-scheduler.xml is not in the classpath i.e with the code
defaults
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656009#action_12656009 ]
Hemanth Yamijala commented on HADOOP-4774:
------------------------------------------
Looks fine. Minor nits:
- Typos in Javadocs: initializatino should be initialization. threasd should be threads
- Also, it is better to mention the units of the INITIALIZATION_THREAD_POLLING_INTERVAL in the Javadoc itself.
> CapacityScheduler should work even if capacity-scheduler.xml is not in the classpath i.e with the code defaults
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4774
> URL: https://issues.apache.org/jira/browse/HADOOP-4774
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Amar Kamat
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-4774-1.patch
>
>
> If I try running capacity-scheduler without having capacity-scheduler.xml in my class path, the jobtracker fails with the following error
> {code}
> Invalid initializater poller interval -1
> {code}
> I feel the problem lies with the default value assigned to it in the code. The capacity-scheduler conf says the default is 5000.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.