You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2018/12/02 21:25:38 UTC

Re: [log4j2] branch new-iso-date-time-formats

On Thu, Nov 29, 2018 at 3:47 PM Gary Gregory <ga...@gmail.com> wrote:

> I mean, here you go:
> https://github.com/apache/logging-log4j2/tree/new-iso-date-time-formats
> :-)
>

So, WDYT? ;-)

GAry

> Gary
>
> On Thu, Nov 29, 2018 at 3:07 PM Remko Popma <re...@gmail.com> wrote:
>
>> Could you send a link so I can browse the branch online? I haven’t had a
>> chance to set up gitbox yet.
>>
>> Remko.
>>
>> > On Nov 30, 2018, at 2:25, Gary Gregory <ga...@gmail.com> wrote:
>> >
>> > ping? :-)
>> >
>> > On Tue, Nov 27, 2018 at 10:51 PM Gary Gregory <ga...@gmail.com>
>> > wrote:
>> >
>> >> Hi Remko Popma
>> >> <
>> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=remkop%40yahoo.com>
>> and
>> >> all:
>> >>
>> >> May you please review the branch new-iso-date-time-formats?
>> >>
>> >> I added support for some ISO date time formats with offset time zones.
>> >>
>> >> Thank you,
>> >> Gary
>> >>
>>
>

Re: [log4j2] branch new-iso-date-time-formats

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Dec 2, 2018 at 5:54 PM Gary Gregory <ga...@gmail.com> wrote:

> On Sun, Dec 2, 2018 at 4:55 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
>> On Sun, Dec 2, 2018 at 3:39 PM Remko Popma <re...@gmail.com> wrote:
>>
>>> Sorry for the late reply.
>>>
>>> Looking at the branch now, but I cannot find what I should be looking
>>> at...
>>> FixedDateFormat looks the same, FastDateFormat looks the same except for
>>> some formatting commits.
>>>
>>> The layouts documentation now has a separate sections with a subset of
>>> the
>>> pre-defined formats and some additional text about using time zones.
>>>
>>> Is it the documentation change that you want me to review?
>>>
>>
>> Ignore this PR https://github.com/apache/logging-log4j2/pull/242, it's a
>> mess. I'll try to clean up...
>>
>
> Crap, not sure what happened but I've lost the changes from the branch :-(
> digging...
>

I hope I did not manage to loose that work. I'll have to look tomorrow
unless you can find it :-(

Gary


>
> Gary
>
>
>>
>> Gary
>>
>>
>>>
>>>
>>>
>>> On Mon, Dec 3, 2018 at 6:25 AM Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>> > On Thu, Nov 29, 2018 at 3:47 PM Gary Gregory <ga...@gmail.com>
>>> > wrote:
>>> >
>>> > > I mean, here you go:
>>> > >
>>> https://github.com/apache/logging-log4j2/tree/new-iso-date-time-formats
>>> > > :-)
>>> > >
>>> >
>>> > So, WDYT? ;-)
>>> >
>>> > GAry
>>> >
>>> > > Gary
>>> > >
>>> > > On Thu, Nov 29, 2018 at 3:07 PM Remko Popma <re...@gmail.com>
>>> > wrote:
>>> > >
>>> > >> Could you send a link so I can browse the branch online? I haven’t
>>> had a
>>> > >> chance to set up gitbox yet.
>>> > >>
>>> > >> Remko.
>>> > >>
>>> > >> > On Nov 30, 2018, at 2:25, Gary Gregory <ga...@gmail.com>
>>> > wrote:
>>> > >> >
>>> > >> > ping? :-)
>>> > >> >
>>> > >> > On Tue, Nov 27, 2018 at 10:51 PM Gary Gregory <
>>> garydgregory@gmail.com
>>> > >
>>> > >> > wrote:
>>> > >> >
>>> > >> >> Hi Remko Popma
>>> > >> >> <
>>> > >>
>>> >
>>> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=remkop%40yahoo.com
>>> > >
>>> > >> and
>>> > >> >> all:
>>> > >> >>
>>> > >> >> May you please review the branch new-iso-date-time-formats?
>>> > >> >>
>>> > >> >> I added support for some ISO date time formats with offset time
>>> > zones.
>>> > >> >>
>>> > >> >> Thank you,
>>> > >> >> Gary
>>> > >> >>
>>> > >>
>>> > >
>>> >
>>>
>>

Re: [log4j2] branch new-iso-date-time-formats

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Dec 2, 2018 at 4:55 PM Gary Gregory <ga...@gmail.com> wrote:

> On Sun, Dec 2, 2018 at 3:39 PM Remko Popma <re...@gmail.com> wrote:
>
>> Sorry for the late reply.
>>
>> Looking at the branch now, but I cannot find what I should be looking
>> at...
>> FixedDateFormat looks the same, FastDateFormat looks the same except for
>> some formatting commits.
>>
>> The layouts documentation now has a separate sections with a subset of the
>> pre-defined formats and some additional text about using time zones.
>>
>> Is it the documentation change that you want me to review?
>>
>
> Ignore this PR https://github.com/apache/logging-log4j2/pull/242, it's a
> mess. I'll try to clean up...
>

Crap, not sure what happened but I've lost the changes from the branch :-(
digging...

Gary


>
> Gary
>
>
>>
>>
>>
>> On Mon, Dec 3, 2018 at 6:25 AM Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>> > On Thu, Nov 29, 2018 at 3:47 PM Gary Gregory <ga...@gmail.com>
>> > wrote:
>> >
>> > > I mean, here you go:
>> > >
>> https://github.com/apache/logging-log4j2/tree/new-iso-date-time-formats
>> > > :-)
>> > >
>> >
>> > So, WDYT? ;-)
>> >
>> > GAry
>> >
>> > > Gary
>> > >
>> > > On Thu, Nov 29, 2018 at 3:07 PM Remko Popma <re...@gmail.com>
>> > wrote:
>> > >
>> > >> Could you send a link so I can browse the branch online? I haven’t
>> had a
>> > >> chance to set up gitbox yet.
>> > >>
>> > >> Remko.
>> > >>
>> > >> > On Nov 30, 2018, at 2:25, Gary Gregory <ga...@gmail.com>
>> > wrote:
>> > >> >
>> > >> > ping? :-)
>> > >> >
>> > >> > On Tue, Nov 27, 2018 at 10:51 PM Gary Gregory <
>> garydgregory@gmail.com
>> > >
>> > >> > wrote:
>> > >> >
>> > >> >> Hi Remko Popma
>> > >> >> <
>> > >>
>> >
>> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=remkop%40yahoo.com
>> > >
>> > >> and
>> > >> >> all:
>> > >> >>
>> > >> >> May you please review the branch new-iso-date-time-formats?
>> > >> >>
>> > >> >> I added support for some ISO date time formats with offset time
>> > zones.
>> > >> >>
>> > >> >> Thank you,
>> > >> >> Gary
>> > >> >>
>> > >>
>> > >
>> >
>>
>

Re: [log4j2] branch new-iso-date-time-formats

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Dec 2, 2018 at 3:39 PM Remko Popma <re...@gmail.com> wrote:

> Sorry for the late reply.
>
> Looking at the branch now, but I cannot find what I should be looking at...
> FixedDateFormat looks the same, FastDateFormat looks the same except for
> some formatting commits.
>
> The layouts documentation now has a separate sections with a subset of the
> pre-defined formats and some additional text about using time zones.
>
> Is it the documentation change that you want me to review?
>

Ignore this PR https://github.com/apache/logging-log4j2/pull/242, it's a
mess. I'll try to clean up...

Gary


>
>
>
> On Mon, Dec 3, 2018 at 6:25 AM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > On Thu, Nov 29, 2018 at 3:47 PM Gary Gregory <ga...@gmail.com>
> > wrote:
> >
> > > I mean, here you go:
> > >
> https://github.com/apache/logging-log4j2/tree/new-iso-date-time-formats
> > > :-)
> > >
> >
> > So, WDYT? ;-)
> >
> > GAry
> >
> > > Gary
> > >
> > > On Thu, Nov 29, 2018 at 3:07 PM Remko Popma <re...@gmail.com>
> > wrote:
> > >
> > >> Could you send a link so I can browse the branch online? I haven’t
> had a
> > >> chance to set up gitbox yet.
> > >>
> > >> Remko.
> > >>
> > >> > On Nov 30, 2018, at 2:25, Gary Gregory <ga...@gmail.com>
> > wrote:
> > >> >
> > >> > ping? :-)
> > >> >
> > >> > On Tue, Nov 27, 2018 at 10:51 PM Gary Gregory <
> garydgregory@gmail.com
> > >
> > >> > wrote:
> > >> >
> > >> >> Hi Remko Popma
> > >> >> <
> > >>
> >
> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=remkop%40yahoo.com
> > >
> > >> and
> > >> >> all:
> > >> >>
> > >> >> May you please review the branch new-iso-date-time-formats?
> > >> >>
> > >> >> I added support for some ISO date time formats with offset time
> > zones.
> > >> >>
> > >> >> Thank you,
> > >> >> Gary
> > >> >>
> > >>
> > >
> >
>

Re: [log4j2] branch new-iso-date-time-formats

Posted by Remko Popma <re...@gmail.com>.
Sorry for the late reply.

Looking at the branch now, but I cannot find what I should be looking at...
FixedDateFormat looks the same, FastDateFormat looks the same except for
some formatting commits.

The layouts documentation now has a separate sections with a subset of the
pre-defined formats and some additional text about using time zones.

Is it the documentation change that you want me to review?



On Mon, Dec 3, 2018 at 6:25 AM Gary Gregory <ga...@gmail.com> wrote:

> On Thu, Nov 29, 2018 at 3:47 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > I mean, here you go:
> > https://github.com/apache/logging-log4j2/tree/new-iso-date-time-formats
> > :-)
> >
>
> So, WDYT? ;-)
>
> GAry
>
> > Gary
> >
> > On Thu, Nov 29, 2018 at 3:07 PM Remko Popma <re...@gmail.com>
> wrote:
> >
> >> Could you send a link so I can browse the branch online? I haven’t had a
> >> chance to set up gitbox yet.
> >>
> >> Remko.
> >>
> >> > On Nov 30, 2018, at 2:25, Gary Gregory <ga...@gmail.com>
> wrote:
> >> >
> >> > ping? :-)
> >> >
> >> > On Tue, Nov 27, 2018 at 10:51 PM Gary Gregory <garydgregory@gmail.com
> >
> >> > wrote:
> >> >
> >> >> Hi Remko Popma
> >> >> <
> >>
> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=remkop%40yahoo.com
> >
> >> and
> >> >> all:
> >> >>
> >> >> May you please review the branch new-iso-date-time-formats?
> >> >>
> >> >> I added support for some ISO date time formats with offset time
> zones.
> >> >>
> >> >> Thank you,
> >> >> Gary
> >> >>
> >>
> >
>