You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/03/20 14:27:58 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new issue, #71: use LazyList instead of Stream in S3Stream
pjfanning opened a new issue, #71:
URL: https://github.com/apache/incubator-pekko-connectors/issues/71
As part of reintroducing Scala 2.12 support, we reverted the Alpakka change to use LazyList and went back to the Scala Stream class.
* we could modify the code so that Scala 2.12 code uses Stream and Scala 2.13+ uses LazyList (new in 2.13 but preferred)
* we could copy in the code from scala-collection-compat that does this or we can write our own - if we use scala-collection-compat code, we will need to update our LICENSE and NOTICE
* we could add a dependency in the s3 module to scala-collection-compat - avoids us having to update our LICENSE and NOTICE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich closed issue #71: use LazyList instead of Stream in S3Stream
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #71: use LazyList instead of Stream in S3Stream
URL: https://github.com/apache/incubator-pekko-connectors/issues/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on issue #71: use LazyList instead of Stream in S3Stream
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #71:
URL: https://github.com/apache/incubator-pekko-connectors/issues/71#issuecomment-1477582645
@mdedetrich this issue is about possibly using LazyList again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on issue #71: use LazyList instead of Stream in S3Stream
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #71:
URL: https://github.com/apache/incubator-pekko-connectors/issues/71#issuecomment-1477636729
> @mdedetrich this issue is about possibly using LazyList again
Ah I see
One thing I want to mention is that the usage of `Stream`/`LazyList` in the first place might be an oversight since Pekko provides its own way to generate a stream of values.
In other words we might be able to just use `Source.repeat` instead of `Stream`/`LazyList.continuously`. Ontop of this `Stream`/`LazyList.continuously` is only being used in tests and the only non test code that uses `Stream`/`LazyList.continuously` is in `S3Stream` functions that are deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on issue #71: use LazyList instead of Stream in S3Stream
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #71:
URL: https://github.com/apache/incubator-pekko-connectors/issues/71#issuecomment-1477643919
@mdedetrich Fair enough. I'm not treating this as an issue with any urgency. It might be best to leave it open for further discussion but I don't intend to make any changes myself based on what you said about the usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich closed issue #71: use LazyList instead of Stream in S3Stream
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #71: use LazyList instead of Stream in S3Stream
URL: https://github.com/apache/incubator-pekko-connectors/issues/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on issue #71: use LazyList instead of Stream in S3Stream
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #71:
URL: https://github.com/apache/incubator-pekko-connectors/issues/71#issuecomment-1477650869
@pjfanning So it took me 10 minutes to do what I suggested, PR is already open (see https://github.com/apache/incubator-pekko-connectors/pull/74).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org