[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade

["Tommy Stendahl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814452#comment-16814452 ] 

Tommy Stendahl commented on CASSANDRA-14412:
--------------------------------------------

It would be nice to have this feature enabled again, it definitely looks like it was removed by mistake. Extending this with snapshots of the {{system_schema}} is a good thing.

I have looked at the patch and it LGTM with one comment:
 * I think the test case {{SystemKeyspaceTest.snapshotSystemKeyspaceIfUpgrading()}} should be extended so it also check the snapshot for {{system_schema}}.

otherwise I'm +1 for this.

> Restore automatic snapshot of system keyspace during upgrade
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-14412
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Startup and Shutdown
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Normal
>             Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in system.local (if any) at startup. If these versions differ, the system keyspace is snapshotted before proceeding in order to enable a rollback if any other issue prevents startup from completing. Although the method to perform this check & snapshot is still present in {{SystemKeyspace}}, its only callsite was mistakenly removed from {{CassandraDaemon}} in CASSANDRA-12716.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org