You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2023/03/22 18:40:14 UTC
[GitHub] [daffodil-vscode] stricklandrbls opened a new pull request, #515: Implement management for selected data.
stricklandrbls opened a new pull request, #515:
URL: https://github.com/apache/daffodil-vscode/pull/515
- Notation added while in single edit byte mode to notify that user of the main editor selection area being disabled and to press ESC to close the single edit byte window, due to the `X` button in that window being `delete` byte instead of close
- Svelte store added for simple lookup of whether selection data is populated even with no content within the editor area. (Multiple byte edit mode).
- Button added to clear the selection data
Closes #512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #515: Implement management for selected data.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515#discussion_r1146081268
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -1662,10 +1684,24 @@ limitations under the License.
display: flex;
}
+ .dataEditor div.measure.selection {
+ flex-direction: column;
+ text-align: center;
+ justify-content: center;
Review Comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #515: Implement management for selected data.
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515#discussion_r1145511332
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -1662,10 +1684,24 @@ limitations under the License.
display: flex;
}
+ .dataEditor div.measure.selection {
+ flex-direction: column;
+ text-align: center;
+ justify-content: center;
Review Comment:
Just pushed an update. Take a look and let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #515: Implement management for selected data.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515#issuecomment-1481112920
Never mind, it works. I just didn't have the S&R populated which is why the Replace button was disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #515: Implement management for selected data.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515#discussion_r1145381637
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -1662,10 +1684,24 @@ limitations under the License.
display: flex;
}
+ .dataEditor div.measure.selection {
+ flex-direction: column;
+ text-align: center;
+ justify-content: center;
Review Comment:
Super minor, but I think ergonomically, speaking the selection text and clear button should be left justified and not centered because it's easier to get to that clear button if it's at a fixed location. Centering it makes it move around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #515: Implement management for selected data.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #515: Implement management for selected data.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #515:
URL: https://github.com/apache/daffodil-vscode/pull/515#discussion_r1145381637
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -1662,10 +1684,24 @@ limitations under the License.
display: flex;
}
+ .dataEditor div.measure.selection {
+ flex-direction: column;
+ text-align: center;
+ justify-content: center;
Review Comment:
Super minor, but I think ergonomically speaking, the selection text and clear button should be left justified and not centered because it's easier to get to that clear button if it's at a fixed location. Centering it makes it move around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org