[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #800: HDDS-3093. Allow forced overwrite of local file

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #800: HDDS-3093. Allow forced overwrite of local file
URL: https://github.com/apache/hadoop-ozone/pull/800#discussion_r406358135
 
 

 ##########
 File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/GetKeyHandler.java
 ##########
 @@ -80,7 +88,7 @@ protected void execute(OzoneClient client, OzoneAddress address)
       IOUtils.copyBytes(input, output, chunkSize);
     }
 
-    if (isVerbose()) {
+    if (isVerbose() && !"/dev/null".equals(dataFile.getAbsolutePath())) {
 
 Review comment:
   Hardcoded path like "/dev/null" may not work in other platforms like Windows. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org