You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by Abrasha <gi...@git.apache.org> on 2016/11/24 00:35:21 UTC

[GitHub] commons-lang pull request #217: LANG-1290: Increase test coverage of org.apa...

GitHub user Abrasha opened a pull request:

    https://github.com/apache/commons-lang/pull/217

    LANG-1290: Increase test coverage of org.apache.commons.lang3.ArrayUtils class

    - fix an issue with not getting Annotation in AnnotaionUtilsTest
    - add tests to cover ArrayUtils
    
    Increased coverage to ~98% lines of code and 100% methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Abrasha/commons-lang improvement/array-util-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #217
    
----
commit 874b18d561ded8888c6f109ff0355d0588282045
Author: Andrii <aa...@gmail.com>
Date:   2016-11-24T00:31:06Z

    add tests to cover ArrayUtils
    fix an issue with not getting Annotation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    @PascalSchumacher, no problem!
    
    ```
    @Test
    public void testAnnotationsOfDifferingTypes() {
        assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field4.getAnnotation(NestAnnotation.class)));
        assertFalse(AnnotationUtils.equals(field4.getAnnotation(NestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));
    }
    ```
    
    This test is successful, but checks a different behaviour than expected.
    
    `field4.getAnnotation(NestAnnotation.class)` is expected to return an annotation of type `NestAnnotation`, but actually it returns `null` because the Retention of annotation is set to default.
    
    As a result, test did not cover quite important case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #217: LANG-1290: Increase test coverage of org.apa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    Thanks for the pull request! \U0001f44d 
    
    >fix an issue with not getting Annotation in AnnotaionUtilsTest
    
    Not sure what you fixed there. What is the reason of this change? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    
    [![Coverage Status](https://coveralls.io/builds/8989909/badge)](https://coveralls.io/builds/8989909)
    
    Coverage increased (+0.6%) to 94.294% when pulling **6362660b3bfb4fb41719496f1037dc3acb0597ea on Abrasha:improvement/array-util-tests** into **41bc4cd029fc486b5570ec344cdeae049bbca860 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    @PascalSchumacher sorry, just for ensure, have changed been merged? 
    Status is: _Closed with unmerged commits_. It is a way of using patches, yes?
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    Great find! \U0001f44d Thanks for the detailed explanation. :)
     
    As this change is unrelated to improving the test coverage of ArrayUtils, it would be nice if you could move it to a separate commit.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    No problem. :)
    
    When I started contributing to Open Source and using git and github I also had a lot of questions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    @PascalSchumacher, thanks, of course everything is ok.
    I just wanted to understand the workflow.
    (I am quiet new to Open Source)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    Yes, the changes have been merged: 51b2cab
    
    I think the commit is marked as unmerged, because I changed the commit message. But you are still listed as the author, so I guess everything is ok?
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    Thanks! \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    It's the same for the other commit, see:
    
    https://github.com/apache/commons-lang/commits/master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    @PascalSchumacher, thanks for note. I will separate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #217: LANG-1290: Increase test coverage of org.apache.com...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/217
  
    
    [![Coverage Status](https://coveralls.io/builds/8976810/badge)](https://coveralls.io/builds/8976810)
    
    Coverage increased (+0.6%) to 94.274% when pulling **874b18d561ded8888c6f109ff0355d0588282045 on Abrasha:improvement/array-util-tests** into **41bc4cd029fc486b5570ec344cdeae049bbca860 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---