You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Dmitriy Lyubimov (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2011/11/19 03:24:51 UTC

[jira] [Issue Comment Edited] (MAHOUT-822) Mahout needs to be made compatible with Hadoop .23 releases

    [ https://issues.apache.org/jira/browse/MAHOUT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153344#comment-13153344 ] 

Dmitriy Lyubimov edited comment on MAHOUT-822 at 11/19/11 2:24 AM:
-------------------------------------------------------------------

bq. Of course, however there is no reason they have to all be done in this JIRA is there?

If i understand our rules correctly, no, we can't commit any single patch while any test is still broken. We have a way to collaborate on those things among several contributors (github comes as a popular option lately), but my understanding we won't be able to push it to the master svn trunk before all issues are fixed. I suggest you create a branch for this issue on the github, this will also help you to stay in sync with trunk more easily ( you can check out my flow here http://weatheringthrutechdays.blogspot.com/2011/04/git-github-and-committing-to-asf-svn.html to see if it helps with this).


On the other hand if this doesn't have to be committed (which seems to be true for as long as it patches for 0.23 rather than some of its stable successors), then this patch may live perhaps indefinitely in form of a jira issue, which is known to happen (perhaps to a larger degree in other projects though).

I anticipated output format problems in SSVD code a post ago and you are basically confirming it. The reason for multiple output acrobatics is that SSVD is written in a 'new' api but last stable hadoop version did not have multiple output support integrated (i had a separate branch for CDH which does have it, though). Hence, it tries to pull old api multiple outputs in a new api environment which worked in that specific hybrid release (and CDH) but i suspect this needs to be finally updated for my inital code that was using CDH new api at this point.
                
      was (Author: dlyubimov):
    bq. Of course, however there is no reason they have to all be done in this JIRA is there?

If i understand our rules correctly, no, we can't commit any single patch while any test is still broken. We have a way to collaborate on those things among several contributors (github comes as a popular option lately), but my understanding we won't be able to push it to the master svn trunk before all issues are fixed.

if this doesn't have to be committed, then this patch may live perhaps indefinitely in form of a jira issue, which is known to happen (perhaps to a larger degree in other projects though).
                  
> Mahout needs to be made compatible with Hadoop .23 releases
> -----------------------------------------------------------
>
>                 Key: MAHOUT-822
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-822
>             Project: Mahout
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.6
>            Reporter: Roman Shaposhnik
>              Labels: bigtop
>         Attachments: MAHOUT-822-build.patch.txt, MAHOUT-822.patch, MAHOUT-822.patch, MAHOUT-822.patch, MAHOUT-822.patch
>
>
> As part of the Hadoop stack integration project (Apache Bigtop) we are now trying to compile Mahout's upcoming 0.6 release against Hadoop 0.22 and 0.23.
> I'm attaching the patch to Mahout's Maven build system that made it possible. I would also like to request help in solving the real issues that poped
> up when we tried to compile Mahout: http://bigtop01.cloudera.org:8080/job/Bigtop-hadoop22/COMPONENT=mahout,label=centos5/6/console
> {noformat}
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/Step0JobTest.java:[182,33] org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/Step0JobTest.java:[218,9] org.apache.mahout.df.mapreduce.partial.Step0JobTest.Step0Context is not abstract and does not override abstract method getInputSplit() in org.apache.hadoop.mapreduce.MapContext
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/Step0JobTest.java:[229,12] cannot find symbol
> [ERROR] symbol  : constructor Context(org.apache.hadoop.conf.Configuration,org.apache.hadoop.mapreduce.TaskAttemptID,<nulltype>,<nulltype>,<nulltype>,<nulltype>,<nulltype>)
> [ERROR] location: class org.apache.hadoop.mapreduce.Mapper.Context
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/common/DummyRecordWriter.java:[68,18] org.apache.hadoop.mapreduce.Mapper.Context is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/common/DummyRecordWriter.java:[77,19] org.apache.hadoop.mapreduce.Reducer.Context is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/PartialSequentialBuilder.java:[110,30] org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/PartialSequentialBuilder.java:[206,28] org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/PartialSequentialBuilder.java:[227,30] org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be instantiated
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/MockContext.java:[30,6] org.apache.mahout.df.mapreduce.partial.MockContext is not abstract and does not override abstract method getInputSplit() in org.apache.hadoop.mapreduce.MapContext
> [ERROR] /mnt/jenkins/workspace/workspace/Bigtop-hadoop22/COMPONENT/mahout/label/centos5/build/mahout/rpm/BUILD/apache-mahout-c298f70/core/src/test/java/org/apache/mahout/df/mapreduce/partial/MockContext.java:[38,10] cannot find symbol
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira