You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/06/15 02:16:01 UTC

[kudu-CR] java: Move static helper functions out of BaseKuduTest 

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10729


Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................

java: Move static helper functions out of BaseKuduTest

This patch factors out several static helper functions from BaseKuduTest
into a new helper library called ClusterTestUtils. The idea is to
eventually make it possible to write a cluster test without extending
BaseKuduTest by relying on composition instead of inheritance.

Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
---
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtils.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
38 files changed, 302 insertions(+), 183 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/10729/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10729 )

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@125
PS3, Line 125:   protected static KuduTable createFourTabletsTableWithNineRows(String tableName) throws
> Sure, I'll move it out. Why that module? This is used in several tests acro
Ah sorry, I didn't realize it was used in so many places.



-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 18:44:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10729 )

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 21:17:45 +0000
Gerrit-HasComments: No

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10729 )

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................

java: Move static helper functions out of BaseKuduTest

This patch factors out several static helper functions from BaseKuduTest
into a new helper library called ClusterTestUtil. The idea is to
eventually make it possible to write a cluster test without extending
BaseKuduTest by relying on composition instead of inheritance.

Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Reviewed-on: http://gerrit.cloudera.org:8080/10729
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-client/src/test/java/org/apache/kudu/util/ClientTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
40 files changed, 342 insertions(+), 220 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10729

to look at the new patch set (#4).

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................

java: Move static helper functions out of BaseKuduTest

This patch factors out several static helper functions from BaseKuduTest
into a new helper library called ClusterTestUtil. The idea is to
eventually make it possible to write a cluster test without extending
BaseKuduTest by relying on composition instead of inheritance.

Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
---
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-client/src/test/java/org/apache/kudu/util/ClientTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
40 files changed, 342 insertions(+), 220 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/10729/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10729 )

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@20
PS3, Line 20: import static org.apache.kudu.util.ClusterTestUtil.getSchemaWithAllTypes;
Are these needed?


http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@125
PS3, Line 125:   protected static KuduTable createFourTabletsTableWithNineRows(String tableName) throws
Can this very specific method be moved too? Maybe to some util in the kudu-client-tools test directory?


http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java
File java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java:

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java@31
PS3, Line 31: public abstract class ClusterTestUtil {
Perhaps ClientTestUtil since it's not really testing a cluster but testing the client functionality (single node or not).



-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 25 Jun 2018 15:36:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10729 )

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@20
PS3, Line 20: import static org.apache.kudu.util.ClusterTestUtil.getSchemaWithAllTypes;
> Are these needed?
I was able to get rid of one by moving out the table creation method, but not the schema ones. Of course there is no good reason for that and it's possible to fix. But I don't want to do that as part of this patch to keep the scope down. We can do it in a follow-up.


http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@125
PS3, Line 125:   protected static KuduTable createFourTabletsTableWithNineRows(String tableName) throws
> Can this very specific method be moved too? Maybe to some util in the kudu-
Sure, I'll move it out. Why that module? This is used in several tests across modules including kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java, kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java, kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java


http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java
File java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java:

http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java@31
PS3, Line 31: public abstract class ClusterTestUtil {
> Perhaps ClientTestUtil since it's not really testing a cluster but testing 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 18:33:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: Move static helper functions out of BaseKuduTest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10729

to look at the new patch set (#3).

Change subject: java: Move static helper functions out of BaseKuduTest
......................................................................

java: Move static helper functions out of BaseKuduTest

This patch factors out several static helper functions from BaseKuduTest
into a new helper library called ClusterTestUtil. The idea is to
eventually make it possible to write a cluster test without extending
BaseKuduTest by relying on composition instead of inheritance.

Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
---
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
37 files changed, 299 insertions(+), 186 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/10729/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c
Gerrit-Change-Number: 10729
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins