You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2021/04/20 09:22:00 UTC
[jira] [Commented] (CALCITE-4583) Make simplification configurable
in "RelBuilder#filter"
[ https://issues.apache.org/jira/browse/CALCITE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325635#comment-17325635 ]
Stamatis Zampetakis commented on CALCITE-4583:
----------------------------------------------
I merged this to master but I just noticed that there was ongoing discussion here, sorry about that.
Truth is that I've seen this as simply a follow up of CALCITE-2338 so I though it is fine to move it forward. Given that there is already an option {{config.simplify()}} that controls simplifications in many other methods of the {{RelBuilder}} I find it more uniform if we also do the same for filters. Worth mentioning that there are use cases where simplification for filters is not necessary (HIVE-21834) so overall the change looks reasonable to me.
> Make simplification configurable in "RelBuilder#filter"
> -------------------------------------------------------
>
> Key: CALCITE-4583
> URL: https://issues.apache.org/jira/browse/CALCITE-4583
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jiatao Tao
> Assignee: Jiatao Tao
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.27.0
>
> Attachments: image-2021-04-15-20-52-15-757.png, image-2021-04-19-10-45-21-768.png, image-2021-04-19-10-45-48-287.png
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Previous in CALCITE-2338, we make simplification configurable in most methods except RelBuilder#filter, this Jira aims to cover this method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)