You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:19:40 UTC
[GitHub] [phoenix] gokceni opened a new pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
gokceni opened a new pull request #788:
URL: https://github.com/apache/phoenix/pull/788
…c for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #788:
URL: https://github.com/apache/phoenix/pull/788#discussion_r430740726
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
##########
@@ -80,6 +81,7 @@
GLOBAL_MUTATION_BYTES(MUTATION_BYTES),
GLOBAL_MUTATION_COMMIT_TIME(MUTATION_COMMIT_TIME),
GLOBAL_MUTATION_BATCH_FAILED_COUNT(MUTATION_BATCH_FAILED_SIZE),
+ GLOBAL_MUTATION_PHASE_THREE_FAILURE_COUNT(PHASE_THREE_FAILURE_SIZE),
Review comment:
Could we have a more descriptive name than PHASE_THREE_FAILURE_COUNT, which is more intuitive if you don't already know a great deal about the indexing pipeline? GLOBAL_MUTATION_INDEX_COMMIT_FAILURE_COUNT maybe? @kadirozde , what do you think would be a good name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 closed pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
Posted by GitBox <gi...@apache.org>.
gjacoby126 closed pull request #788:
URL: https://github.com/apache/phoenix/pull/788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #788:
URL: https://github.com/apache/phoenix/pull/788#issuecomment-741007708
JIRA is resolved, closing PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] swaroopak commented on a change in pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #788:
URL: https://github.com/apache/phoenix/pull/788#discussion_r430719272
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/BasePhoenixMetricsIT.java
##########
@@ -110,7 +110,7 @@ void assertMutationMetrics(String tableName, int numRows, Map<String, Map<Metric
String t = entry.getKey();
assertEquals("Table name didn't match for mutation metrics", tableName, t);
Map<MetricType, Long> p = entry.getValue();
- assertEquals("There should have been four metrics", 4, p.size());
+ assertEquals("There should have been four metrics", 5, p.size());
Review comment:
nit: five in the text or can use the number in place of text by assigning it to a variable.
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
##########
@@ -329,7 +333,7 @@ public void testMetricsForUpsert() throws Exception {
String t = entry.getKey();
assertEquals("Table names didn't match!", tableName, t);
Map<MetricType, Long> p = entry.getValue();
- assertEquals("There should have been four metrics", 4, p.size());
+ assertEquals("There should have been four metrics", 5, p.size());
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #788: PHOENIX-5921 Shorten verification phase fail log line and add a metri…
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #788:
URL: https://github.com/apache/phoenix/pull/788#discussion_r430746465
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
##########
@@ -80,6 +81,7 @@
GLOBAL_MUTATION_BYTES(MUTATION_BYTES),
GLOBAL_MUTATION_COMMIT_TIME(MUTATION_COMMIT_TIME),
GLOBAL_MUTATION_BATCH_FAILED_COUNT(MUTATION_BATCH_FAILED_SIZE),
+ GLOBAL_MUTATION_PHASE_THREE_FAILURE_COUNT(PHASE_THREE_FAILURE_SIZE),
Review comment:
@gjacoby126, GLOBAL_MUTATION_INDEX_COMMIT_FAILURE_COUNT sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org