[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #13677: ARROW-17089: [Python] Use `.arrow` as extension for IPC file dataset

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #13677:
URL: https://github.com/apache/arrow/pull/13677#discussion_r957076412


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -4192,27 +4192,27 @@ def test_write_table_multiple_fragments(tempdir):
     # Table with multiple batches written as single Fragment by default
     base_dir = tempdir / 'single'
     ds.write_dataset(table, base_dir, format="feather")
-    assert set(base_dir.rglob("*")) == set([base_dir / "part-0.feather"])
+    assert set(base_dir.rglob("*")) == set([base_dir / "part-0.arrow"])
     assert ds.dataset(base_dir, format="ipc").to_table().equals(table)
 
     # Same for single-element list of Table
     base_dir = tempdir / 'single-list'
     ds.write_dataset([table], base_dir, format="feather")
-    assert set(base_dir.rglob("*")) == set([base_dir / "part-0.feather"])
+    assert set(base_dir.rglob("*")) == set([base_dir / "part-0.arrow"])
     assert ds.dataset(base_dir, format="ipc").to_table().equals(table)
 
     # Provide list of batches to write multiple fragments
     base_dir = tempdir / 'multiple'
     ds.write_dataset(table.to_batches(), base_dir, format="feather")
     assert set(base_dir.rglob("*")) == set(
-        [base_dir / "part-0.feather"])
+        [base_dir / "part-0.arrow"])

Review Comment:
   Personally, I am +1 on the suggestion of @kou for having a small FeatherFileFormat class so that we can let the default extension name depend on whether the user specified `format="ipc"` vs `format="feather"` (for the reasons @kou gave).  
   I am only wondering if we can avoid making that public, so it's only used under the hood if the user passed a string format name to write_dataset.
   
   (I also do think it might be worth a broader discussion about to which extent and how we want to keep using the Feather name)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org