You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/22 08:18:42 UTC
Review Request 38599: Consistent use of case insensitive keys for HTTP
headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38599/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
A number of places in the code were not using case insensitive header keys, these are the fixes within mesos that leverage the typedef from [r/38600](https://reviews.apache.org/r/38600).
Diffs
-----
src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
src/slave/containerizer/provisioners/docker/registry_client.cpp b262ef031e0373ee009273e50a16d0a58ed83e8e
src/tests/http_api_tests.cpp 7938bbbb1edade8fa092118baab63f85a83b4ca2
src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
src/tests/reservation_endpoints_tests.cpp 398a2e11cb334095f16b9e5529e6715e633d2c6f
src/tests/teardown_tests.cpp daf748c1e128dc296b075fd7152dd9393def9d65
Diff: https://reviews.apache.org/r/38599/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38599: Consistent use of case insensitive keys for
HTTP headers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38599/#review100291
-----------------------------------------------------------
Ship it!
Thanks for the cleanup!
- Vinod Kone
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38599/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A number of places in the code were not using case insensitive header keys, these are the fixes within mesos that leverage the typedef from [r/38600](https://reviews.apache.org/r/38600).
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
> src/slave/containerizer/provisioners/docker/registry_client.cpp b262ef031e0373ee009273e50a16d0a58ed83e8e
> src/tests/http_api_tests.cpp 7938bbbb1edade8fa092118baab63f85a83b4ca2
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/reservation_endpoints_tests.cpp 398a2e11cb334095f16b9e5529e6715e633d2c6f
> src/tests/teardown_tests.cpp daf748c1e128dc296b075fd7152dd9393def9d65
>
> Diff: https://reviews.apache.org/r/38599/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38599: Consistent use of case insensitive keys for
HTTP headers.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38599/#review100088
-----------------------------------------------------------
Ship it!
LGTM ! Thanks for taking the time to do a sweep across the project.
- Anand Mazumdar
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38599/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A number of places in the code were not using case insensitive header keys, these are the fixes within mesos that leverage the typedef from [r/38600](https://reviews.apache.org/r/38600).
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
> src/slave/containerizer/provisioners/docker/registry_client.cpp b262ef031e0373ee009273e50a16d0a58ed83e8e
> src/tests/http_api_tests.cpp 7938bbbb1edade8fa092118baab63f85a83b4ca2
> src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91
> src/tests/reservation_endpoints_tests.cpp 398a2e11cb334095f16b9e5529e6715e633d2c6f
> src/tests/teardown_tests.cpp daf748c1e128dc296b075fd7152dd9393def9d65
>
> Diff: https://reviews.apache.org/r/38599/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>