You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "flyrain (via GitHub)" <gi...@apache.org> on 2026/04/23 00:30:16 UTC
[PR] Regtests: harden MinIO client download and fail fast when setup breaks [polaris]
flyrain opened a new pull request, #4279:
URL: https://github.com/apache/polaris/pull/4279
Fix a test failure like this, https://github.com/apache/polaris/actions/runs/24807004136/job/72603400304
The `mc` binary is fetched in the Docker build with plain `curl -o`, so a transient HTTP error or partial response produces a corrupted file that silently passes `chmod +x`. When `minio-setup.sh` later invokes it, the shell reports `line 1: a: No such file or directory` and exits; but `run.sh` does not check the setup script's exit code, so tests proceed against a bucket that was never created and fail with "The specified bucket does not exist" โ masking the real cause behind a dozen pyspark regression failures.
- Dockerfile: use `curl -fL --retry 5 --retry-delay 2 --retry-connrefused` and run `mc --version` so a bad download fails the image build.
- run.sh: abort the run if `minio-setup.sh` exits non-zero.
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Regtests: harden MinIO client download and fail fast when setup breaks [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #4279:
URL: https://github.com/apache/polaris/pull/4279#discussion_r3128194060
##########
regtests/Dockerfile:
##########
@@ -32,8 +32,10 @@ RUN apt-get update && \
mkdir -p /home/spark /tmp/polaris-regtests /opt/spark/conf && \
chown -R spark:spark /home/spark /tmp/polaris-regtests && \
chmod -R 777 /opt/spark/conf && \
- curl -o /usr/local/bin/mc https://dl.min.io/client/mc/release/linux-amd64/mc && \
- chmod +x /usr/local/bin/mc
+ curl -fL --retry 5 --retry-delay 2 --retry-connrefused \
Review Comment:
Missing`&&` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Regtests: harden MinIO client download and fail fast when setup breaks [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #4279:
URL: https://github.com/apache/polaris/pull/4279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Regtests: harden MinIO client download and fail fast when setup breaks [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #4279:
URL: https://github.com/apache/polaris/pull/4279#issuecomment-4301063579
Thanks for the fix @flyrain . I will work on changing this to aws cli later and add support for rustfs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Regtests: harden MinIO client download and fail fast when setup breaks [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #4279:
URL: https://github.com/apache/polaris/pull/4279#discussion_r3128194060
##########
regtests/Dockerfile:
##########
@@ -32,8 +32,10 @@ RUN apt-get update && \
mkdir -p /home/spark /tmp/polaris-regtests /opt/spark/conf && \
chown -R spark:spark /home/spark /tmp/polaris-regtests && \
chmod -R 777 /opt/spark/conf && \
- curl -o /usr/local/bin/mc https://dl.min.io/client/mc/release/linux-amd64/mc && \
- chmod +x /usr/local/bin/mc
+ curl -fL --retry 5 --retry-delay 2 --retry-connrefused \
Review Comment:
Missing`&&` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org