You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:58:00 UTC

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5332: Detect segments which are in ERROR state on all replicas

Jackie-Jiang commented on pull request #5332:
URL: https://github.com/apache/incubator-pinot/pull/5332#issuecomment-624243740


   > Based on an offline discussion with @kishoreg :
   > 
   > Why not introduce a method in RoutingManager as:
   > `RoutingTable getRoutingTable(BrokerRequest)`
   > 
   > where
   > 
   > `RoutingTable` contains the map and the set of unavailable segments.
   
   +1. And also the logic should not be in RoutingManager but in InstanceSelector. Manager should not perform the actual calculation.
   It's a little bit hard to describe with comments, I'll create a pr demonstrating the idea


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org