You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/07/25 23:46:14 UTC
Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/
-----------------------------------------------------------
Review request for mesos and Qian Zhang.
Repository: mesos
Description
-------
Made the log messages more consistent and also added one for adding
an executor.
Diffs
-----
src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32
Diff: https://reviews.apache.org/r/61128/diff/1/
Testing
-------
None
Thanks,
Vinod Kone
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/#review190090
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61128]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 25, 2017, 11:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61128/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 11:46 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the log messages more consistent and also added one for adding
> an executor.
>
>
> Diffs
> -----
>
> src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32
>
>
> Diff: https://reviews.apache.org/r/61128/diff/1/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/#review181420
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61128]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 25, 2017, 11:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61128/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 11:46 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the log messages more consistent and also added one for adding
> an executor.
>
>
> Diffs
> -----
>
> src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32
>
>
> Diff: https://reviews.apache.org/r/61128/diff/1/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/#review210585
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['61128']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2604/mesos-review-61128
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2604/mesos-review-61128/logs/mesos-tests.log):
```
I1115 22:41:27.024873 29512 master.cpp:11076] Removing task 8e31bf15-cfe7-4303-8f15-1fbafda7a537 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework d6d06aac-19b4-4d66-8594-7919d37ab4da-0000 on agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0 at slave(461)@192.10.1.5:63177 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1115 22:41:27.027690 29512 master.cpp:1273] Agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0 at slave(461)@192.10.1.5:63177 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1115 22:41:27.027690 29512 master.cpp:3289] Disconnecting agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0 at slave(461)@192.10.1.5:63177 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1115 22:41:27.027690 29512 master.cpp:3308] Deactivating agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0 at slave(461)@192.10.1.5:63177 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1115 22:41:27.028690 33512 hierarchical.cpp:357] Removed framework d6d06aac-19b4-4d66-8594-7919d37ab4da-0000
I1115 22:41:27.029692 33512 hierarchical.cpp:801] Agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0 deactivated
I1115 22:41:27.029692 35704 containerizer.cpp:2465] Destroying container 3a1df83b-26a9-4430-af9b-c0c167f102f2 in RUNNING state
I1115 22:41:27.029692 35704 containerizer.cpp:3132] Transitioning the state of container 3a1df83b-26a9-4430-af9b-c0c167f102f2 from RUNNING to DESTROYING
I1115 22:41:27.030736 35704 launcher.cpp:161] Asked to destroy container 3a1df83b-26a9-4430-af9b-c0c167f102f2
W1115 22:41:27.031713 31376 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=3620 to peer '192.10.1.5:64988': IO failed with error code: The specified network name is no longer available.
W1115 22:41:27.031713 31376 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=1336 to peer '192.10[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)
[----------] Global test environment tear-down
[==========] 1053 tests from 103 test cases ran. (500109 ms total)
[ PASSED ] 1052 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
.1.5:64989': IO failed with error code: The specified network name is no longer available.
I1115 22:41:27.070714 33512 containerizer.cpp:2971] Container 3a1df83b-26a9-4430-af9b-c0c167f102f2 has exited
I1115 22:41:27.104754 33056 master.cpp:1115] Master terminating
I1115 22:41:27.105689 33512 hierarchical.cpp:643] Removed agent d6d06aac-19b4-4d66-8594-7919d37ab4da-S0
I1115 22:41:27.681699 31376 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Nov. 15, 2018, 9:40 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61128/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2018, 9:40 p.m.)
>
>
> Review request for mesos, Benno Evers and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the log messages and the calling sites consistent and also added
> one for adding an executor.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40
>
>
> Diff: https://reviews.apache.org/r/61128/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/
-----------------------------------------------------------
(Updated Nov. 15, 2018, 9:40 p.m.)
Review request for mesos, Benno Evers and Qian Zhang.
Repository: mesos
Description
-------
Made the log messages and the calling sites consistent and also added
one for adding an executor.
Diffs (updated)
-----
src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40
Diff: https://reviews.apache.org/r/61128/diff/3/
Changes: https://reviews.apache.org/r/61128/diff/2-3/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 1:33 a.m.)
Review request for mesos, Benno Evers and Qian Zhang.
Changes
-------
qian's comments.
Repository: mesos
Description (updated)
-------
Made the log messages and the calling sites consistent and also added
one for adding an executor.
Diffs (updated)
-----
src/master/master.cpp 16cdde73b90b2e1514c6196850b8df75a3b6ff28
Diff: https://reviews.apache.org/r/61128/diff/2/
Changes: https://reviews.apache.org/r/61128/diff/1-2/
Testing (updated)
-------
make check
Thanks,
Vinod Kone
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Vinod Kone <vi...@apache.org>.
> On Nov. 7, 2017, 12:37 a.m., Qian Zhang wrote:
> > src/master/master.cpp
> > Lines 9674-9676 (original), 9675-9678 (patched)
> > <https://reviews.apache.org/r/61128/diff/1/?file=1782402#file1782402line9675>
> >
> > To be consistent with this log message, I think we also need to change the log message in `Master::removeTask()` from:
> > ```
> > LOG(INFO) << "Removing task " << task->task_id()
> > << " with resources " << task->resources()
> > << " of framework " << task->framework_id()
> > << " on agent " << *slave;
> > ```
> > to:
> > ```
> > LOG(INFO) << "Removing task " << task->task_id()
> > << " of framework " << task->framework_id()
> > << " with resources " << task->resources()
> > << " on agent " << *slave;
> > ```
> > And there is also a warning message in `Master::removeTask()`, I think we need to change that one too.
Made it consistent. Also moved the location of the logs to be consistent.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/#review190253
-----------------------------------------------------------
On Dec. 6, 2017, 1:33 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61128/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 1:33 a.m.)
>
>
> Review request for mesos, Benno Evers and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the log messages and the calling sites consistent and also added
> one for adding an executor.
>
>
> Diffs
> -----
>
> src/master/master.cpp 16cdde73b90b2e1514c6196850b8df75a3b6ff28
>
>
> Diff: https://reviews.apache.org/r/61128/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 61128: Improved log messages in master when
adding/removing tasks/executors.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61128/#review190253
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 9674-9676 (original), 9675-9678 (patched)
<https://reviews.apache.org/r/61128/#comment267556>
To be consistent with this log message, I think we also need to change the log message in `Master::removeTask()` from:
```
LOG(INFO) << "Removing task " << task->task_id()
<< " with resources " << task->resources()
<< " of framework " << task->framework_id()
<< " on agent " << *slave;
```
to:
```
LOG(INFO) << "Removing task " << task->task_id()
<< " of framework " << task->framework_id()
<< " with resources " << task->resources()
<< " on agent " << *slave;
```
And there is also a warning message in `Master::removeTask()`, I think we need to change that one too.
- Qian Zhang
On July 26, 2017, 7:46 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61128/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 7:46 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the log messages more consistent and also added one for adding
> an executor.
>
>
> Diffs
> -----
>
> src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32
>
>
> Diff: https://reviews.apache.org/r/61128/diff/1/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Vinod Kone
>
>