You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/02/16 03:21:29 UTC
[incubator-doris-spark-connector] 42/50: [refactor](spark-connector) delete useless maven dependencies and some code variable definition issues (#7655)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git
commit ecc7633b5b649250112b717eff9515f34edabcec
Author: jiafeng.zhang <zh...@gmail.com>
AuthorDate: Sun Jan 9 16:58:16 2022 +0800
[refactor](spark-connector) delete useless maven dependencies and some code variable definition issues (#7655)
---
src/main/java/org/apache/doris/spark/backend/BackendClient.java | 2 +-
src/main/java/org/apache/doris/spark/cfg/Settings.java | 2 +-
src/main/java/org/apache/doris/spark/rest/RestService.java | 6 +++---
src/main/java/org/apache/doris/spark/serialization/Routing.java | 2 +-
src/main/java/org/apache/doris/spark/util/IOUtils.java | 1 -
src/test/java/org/apache/doris/spark/rest/TestRestService.java | 2 +-
.../java/org/apache/doris/spark/serialization/TestRowBatch.java | 2 +-
7 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/doris/spark/backend/BackendClient.java b/src/main/java/org/apache/doris/spark/backend/BackendClient.java
index b5f6112..ad11003 100644
--- a/src/main/java/org/apache/doris/spark/backend/BackendClient.java
+++ b/src/main/java/org/apache/doris/spark/backend/BackendClient.java
@@ -45,7 +45,7 @@ import org.slf4j.LoggerFactory;
* Client to request Doris BE
*/
public class BackendClient {
- private static Logger logger = LoggerFactory.getLogger(BackendClient.class);
+ private final static Logger logger = LoggerFactory.getLogger(BackendClient.class);
private Routing routing;
diff --git a/src/main/java/org/apache/doris/spark/cfg/Settings.java b/src/main/java/org/apache/doris/spark/cfg/Settings.java
index 4e376a4..23f0cd7 100644
--- a/src/main/java/org/apache/doris/spark/cfg/Settings.java
+++ b/src/main/java/org/apache/doris/spark/cfg/Settings.java
@@ -29,7 +29,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public abstract class Settings {
- private static Logger logger = LoggerFactory.getLogger(Settings.class);
+ private final static Logger logger = LoggerFactory.getLogger(Settings.class);
public abstract String getProperty(String name);
diff --git a/src/main/java/org/apache/doris/spark/rest/RestService.java b/src/main/java/org/apache/doris/spark/rest/RestService.java
index e8a2956..e1f9a81 100644
--- a/src/main/java/org/apache/doris/spark/rest/RestService.java
+++ b/src/main/java/org/apache/doris/spark/rest/RestService.java
@@ -174,16 +174,16 @@ public class RestService implements Serializable {
connection.getURL(), connection.getResponseCode());
throw new IOException("Failed to get response from Doris");
}
- String result = "";
+ StringBuilder result = new StringBuilder("");
BufferedReader in = new BufferedReader(new InputStreamReader(connection.getInputStream(), "utf-8"));
String line;
while ((line = in.readLine()) != null) {
- result += line;
+ result.append(line);
}
if (in != null) {
in.close();
}
- return result;
+ return result.toString();
}
private static String getConnectionPost(HttpRequestBase request,String user, String passwd,Logger logger) throws IOException {
diff --git a/src/main/java/org/apache/doris/spark/serialization/Routing.java b/src/main/java/org/apache/doris/spark/serialization/Routing.java
index 0754ff6..e47eedd 100644
--- a/src/main/java/org/apache/doris/spark/serialization/Routing.java
+++ b/src/main/java/org/apache/doris/spark/serialization/Routing.java
@@ -27,7 +27,7 @@ import org.slf4j.LoggerFactory;
* present an Doris BE address.
*/
public class Routing {
- private static Logger logger = LoggerFactory.getLogger(Routing.class);
+ private final static Logger logger = LoggerFactory.getLogger(Routing.class);
private String host;
private int port;
diff --git a/src/main/java/org/apache/doris/spark/util/IOUtils.java b/src/main/java/org/apache/doris/spark/util/IOUtils.java
index d673acb..03a9e00 100644
--- a/src/main/java/org/apache/doris/spark/util/IOUtils.java
+++ b/src/main/java/org/apache/doris/spark/util/IOUtils.java
@@ -22,7 +22,6 @@ import java.io.StringReader;
import java.io.StringWriter;
import java.util.Properties;
-import org.apache.doris.spark.exception.DorisException;
import org.apache.doris.spark.exception.IllegalArgumentException;
public class IOUtils {
diff --git a/src/test/java/org/apache/doris/spark/rest/TestRestService.java b/src/test/java/org/apache/doris/spark/rest/TestRestService.java
index 22d542a..5862dd0 100644
--- a/src/test/java/org/apache/doris/spark/rest/TestRestService.java
+++ b/src/test/java/org/apache/doris/spark/rest/TestRestService.java
@@ -53,7 +53,7 @@ import org.slf4j.LoggerFactory;
import jdk.nashorn.internal.ir.annotations.Ignore;
public class TestRestService {
- private static Logger logger = LoggerFactory.getLogger(TestRestService.class);
+ private final static Logger logger = LoggerFactory.getLogger(TestRestService.class);
@Rule
public ExpectedException thrown = ExpectedException.none();
diff --git a/src/test/java/org/apache/doris/spark/serialization/TestRowBatch.java b/src/test/java/org/apache/doris/spark/serialization/TestRowBatch.java
index e5f5ee7..ad0f150 100644
--- a/src/test/java/org/apache/doris/spark/serialization/TestRowBatch.java
+++ b/src/test/java/org/apache/doris/spark/serialization/TestRowBatch.java
@@ -60,7 +60,7 @@ import org.slf4j.LoggerFactory;
import com.google.common.collect.ImmutableList;
public class TestRowBatch {
- private static Logger logger = LoggerFactory.getLogger(TestRowBatch.class);
+ private final static Logger logger = LoggerFactory.getLogger(TestRowBatch.class);
@Rule
public ExpectedException thrown = ExpectedException.none();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org