You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/06 01:14:32 UTC

[GitHub] GabeLoins commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

GabeLoins commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin
URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179639918
 
 

 ##########
 File path: superset/assets/javascripts/utils/common.js
 ##########
 @@ -86,3 +86,12 @@ export function getShortUrl(longUrl, callback) {
     },
   });
 }
+
+export function isTruthy(obj) {
 
 Review comment:
   acknowledging I have very little context here- this seems like a bad road to go down. We use YAML for plenty of stuff over here and there have been many issues caused by someone not expecting `True`/`t`/`yes` to be true... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services