You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "be-a-panther (via GitHub)" <gi...@apache.org> on 2025/06/25 09:02:11 UTC

[I] CLIENT INFO redis-py broken [kvrocks]

be-a-panther opened a new issue, #3038:
URL: https://github.com/apache/kvrocks/issues/3038

   ### Search before asking
   
   - [x] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   ref: 
   https://github.com/redis/redis-py/blob/0d0cfe66eaa541dfc078398f37277e5de8d11dc8/redis/_parsers/helpers.py#L662-L679
   
    kvrocks return the following content:
   ```
   {'id': '14620', 'addr': '172.17.0.1:58222', 'fd': '51', 'name': '', 'age': '0', 'idle': '0', 'flags': 'N', 'namespace': 'ns1', 'qbuf': '0', 'obuf': '0', 'cmd': 'client'} 
   ```
   redis:latest return the following content:
   ```
   {'id': '18', 'addr': '172.17.0.1:46410', 'laddr': '172.17.0.3:6379', 'fd': '22', 'name': '', 'age': '0', 'idle': '0', 'flags': 'N', 'db': '0', 'sub': '0', 'psub': '0', 'ssub': '0', 'multi': '-1', 'watch': '0', 'qbuf': '26', 'qbuf-free': '20448', 'argv-mem': '10', 'multi-mem': '0', 'rbs': '16384', 'rbp': '16384', 'obl': '0', 'oll': '0', 'omem': '0', 'tot-mem': '37786', 'events': 'r', 'cmd': 'client|info', 'user': 'default', 'redir': '-1', 'resp': '2', 'lib-name': 'redis-py', 'lib-ver': '6.2.0', 'io-thread': '0'} 
   ```
   
   ```
   File "/home/user/src/bloomfilter/pss-tools/.venv/lib/python3.13/site-packages/redis/_parsers/helpers.py", line 679, in parse_client_info 
       client_info[int_key] = int(client_info[int_key]) 
   
   KeyError: 'sub'
   ```
   
   If I'm understanding this correctly, the python library expects more key values, which should be delivered. 
   ref: https://github.com/redis/redis/blob/080b99d9827eac9e8a6639922d64b8a8cc5c930c/src/networking.c#L2824C1-L2824C265
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CLIENT INFO redis-py broken [kvrocks]

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #3038:
URL: https://github.com/apache/kvrocks/issues/3038#issuecomment-3062729964

   @be-a-panther This issue should be resolved after PR https://github.com/redis/redis-py/pull/3688. cc @PragmaTwice 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CLIENT INFO redis-py broken [kvrocks]

Posted by "guozhihao-224 (via GitHub)" <gi...@apache.org>.
guozhihao-224 commented on issue #3038:
URL: https://github.com/apache/kvrocks/issues/3038#issuecomment-3212932886

   Can I do this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CLIENT INFO redis-py broken [kvrocks]

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed issue #3038: CLIENT INFO redis-py broken
URL: https://github.com/apache/kvrocks/issues/3038


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CLIENT INFO redis-py broken [kvrocks]

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #3038:
URL: https://github.com/apache/kvrocks/issues/3038#issuecomment-3212942092

   It seems https://github.com/redis/redis-py/pull/3688 is merged so this issue can be closed as resolved.
   
   Feel free to open new issues for it if you find something that can be improved. @guozhihao-224 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org