You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by pt...@apache.org on 2009/02/05 13:40:23 UTC
svn commit: r741091 - in
/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus:
./ internal/ internal/client/connector/http/ internal/server/ spi/server/
util/
Author: ptahchiev
Date: Thu Feb 5 12:40:21 2009
New Revision: 741091
URL: http://svn.apache.org/viewvc?rev=741091&view=rev
Log:
Checkstyle improved.
Modified:
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/EJBRequest.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/ServiceDefinition.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/EJBTestResult.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/AbstractEJBTestCaller.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/BeanImplicitObjects.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBImplicitObjects.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestCaller.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestController.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestCaller.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestController.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanImplicitObjects.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanRedirector.java
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/EJBRequest.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/EJBRequest.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/EJBRequest.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/EJBRequest.java Thu Feb 5 12:40:21 2009
@@ -27,7 +27,8 @@
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public class EJBRequest implements Request, Serializable
{
@@ -47,8 +48,8 @@
/**
* A method to set the name of the class as a request parameter.
- * @param theClassKey
- * @param theName
+ * @param theClassKey to set to
+ * @param theName to set
*/
public void setClassName(String theClassKey, String theName)
{
@@ -57,8 +58,9 @@
/**
* A method to get the name of the class as a request parameter.
- * @param theClassKey
- * @return
+ *
+ * @param theClassKey the parameter
+ * @return the name of the class
*/
public String getClassName(String theClassKey)
{
@@ -67,8 +69,8 @@
/**
* A method to set the name of the test-method.
- * @param theMethodKey
- * @param theName
+ * @param theMethodKey the method-key
+ * @param theName the name of the method
*/
public void setMethodName(String theMethodKey, String theName)
{
@@ -77,8 +79,9 @@
/**
* Getter method for the name of the test-method.
- * @param theMethodKey
- * @return
+ *
+ * @param theMethodKey the parameter
+ * @return the name of the method
*/
public String getMethodName(String theMethodKey)
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/ServiceDefinition.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/ServiceDefinition.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/ServiceDefinition.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/ServiceDefinition.java Thu Feb 5 12:40:21 2009
@@ -24,8 +24,6 @@
* Constants that define HTTP parameters required for defining a service that
* is performed by the <code>ServletTestRedirector</code> servlet.
*
- * @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
- *
* @version $Id$
*/
public class ServiceDefinition
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/EJBTestResult.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/EJBTestResult.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/EJBTestResult.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/EJBTestResult.java Thu Feb 5 12:40:21 2009
@@ -1,4 +1,3 @@
-package org.apache.cactus.internal;
/*
* ========================================================================
*
@@ -19,18 +18,21 @@
*
* ========================================================================
*/
+package org.apache.cactus.internal;
+
import java.io.PrintWriter;
import java.io.StringWriter;
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public class EJBTestResult
{
/**
- * Name of the exception class if an error occurred
- */
+ * Name of the exception class if an error occurred.
+ */
private String exceptionClassName;
/**
@@ -41,7 +43,7 @@
private String exceptionStackTrace;
/**
- * The exception message if an error occurred
+ * The exception message if an error occurred.
*/
private String exceptionMessage;
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java Thu Feb 5 12:40:21 2009
@@ -37,7 +37,8 @@
/**
* The JMS protocol handler.
- * @author ptahchiev
+ *
+ * @version $Id$
*/
public class JmsProtocolHandler implements ProtocolHandler
{
@@ -47,6 +48,9 @@
*/
private JmsConfiguration configuration;
+ /**
+ * The session.
+ */
private QueueSession session;
/**
@@ -59,7 +63,9 @@
/**
* A method that gets executed after the test execution.
- * @param theProtocolState the state of the protocol after the execution.
+ *
+ * @param theState the state of the protocol after the execution.
+ * @throws Exception in case of error
*/
public void afterTest(ProtocolState theState) throws Exception
{
@@ -70,7 +76,8 @@
* A method to create a request object.
* @return Request
*/
- public Request createRequest() {
+ public Request createRequest()
+ {
return new JmsRequest(session);
}
@@ -86,9 +93,11 @@
/**
* The method that actually runs the tests.
*
- * @param theDelegatedTest
- * @param theWrappedTest
- * @param theRequest
+ * @param theDelegatedTest parameter
+ * @param theWrappedTest parameter
+ * @param theRequest parameter
+ * @return the protocol state
+ * @throws Throwable in case of error
*/
public ProtocolState runTest(Test theDelegatedTest, Test theWrappedTest,
Request theRequest) throws Throwable
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/AbstractEJBTestCaller.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/AbstractEJBTestCaller.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/AbstractEJBTestCaller.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/AbstractEJBTestCaller.java Thu Feb 5 12:40:21 2009
@@ -1,4 +1,3 @@
-package org.apache.cactus.internal.server;
/*
* ========================================================================
*
@@ -19,6 +18,8 @@
*
* ========================================================================
*/
+package org.apache.cactus.internal.server;
+
import java.lang.reflect.Constructor;
import org.apache.cactus.internal.AbstractCactusTestCase;
import org.apache.cactus.internal.EJBTestResult;
@@ -29,7 +30,8 @@
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public abstract class AbstractEJBTestCaller
{
@@ -47,7 +49,7 @@
/**
* A constructor for the class.
- * @param theObjects
+ * @param theObjects parameter
*/
public AbstractEJBTestCaller(EJBImplicitObjects theObjects)
{
@@ -56,7 +58,8 @@
/**
* Setter method to set the test-case fields.
- * @param theTestCase
+ *
+ * @param theTestCase parameter
* @throws Exception in case an error occurs.
*/
protected abstract void setTestCaseFields(AbstractCactusTestCase
@@ -103,7 +106,8 @@
/**
* Getter method to return the name of the class being tested.
- * @return
+ *
+ * @return the class name
*/
protected String getTestClassName()
{
@@ -113,7 +117,8 @@
/**
* Getter method to return the name of the test-method being executed.
- * @return
+ *
+ * @return the method-name
* @throws Exception in case an error occurs
*/
protected String getTestMethodName() throws Exception
@@ -124,9 +129,9 @@
/**
* A method to return an instance of the test-class.
- * @param theClassName
- * @param theTestCaseName
- * @return
+ * @param theClassName parameter
+ * @param theTestCaseName parameter
+ * @return the cactus test-case
* @throws Exception in case an error occurs
*/
protected AbstractCactusTestCase getTestClassInstance(
@@ -140,10 +145,10 @@
try
{
Constructor constructor =
- testClass.getConstructor(new Class[] { String.class });
+ testClass.getConstructor(new Class[] {String.class});
testInstance =
(AbstractCactusTestCase) constructor.newInstance(
- new Object[] { theTestCaseName });
+ new Object[] {theTestCaseName});
}
catch (Exception e)
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/BeanImplicitObjects.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/BeanImplicitObjects.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/BeanImplicitObjects.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/BeanImplicitObjects.java Thu Feb 5 12:40:21 2009
@@ -1,4 +1,3 @@
-package org.apache.cactus.internal.server;
/*
* ========================================================================
*
@@ -19,12 +18,15 @@
*
* ========================================================================
*/
+package org.apache.cactus.internal.server;
+
import javax.ejb.SessionContext;
import org.apache.cactus.EJBRequest;
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public class BeanImplicitObjects implements EJBImplicitObjects
{
@@ -40,6 +42,8 @@
/**
* Getter method for the ejb context.
+ *
+ * @return the ejb-context
*/
public SessionContext getEJBContext()
{
@@ -48,7 +52,7 @@
/**
* Setter method for the ejb context.
- * @param theContext
+ * @param theContext to set
*/
public void setEJBContext(SessionContext theContext)
{
@@ -57,6 +61,7 @@
/**
* Getter method for the ejb request.
+ *
* @return ejb request object
*/
public EJBRequest getEJBRequest()
@@ -66,7 +71,8 @@
/**
* Setter method for the ejb request.
- * @param theRequest
+ *
+ * @param theRequest to set
*/
public void setEJBRequest(EJBRequest theRequest)
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBImplicitObjects.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBImplicitObjects.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBImplicitObjects.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBImplicitObjects.java Thu Feb 5 12:40:21 2009
@@ -26,32 +26,37 @@
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public interface EJBImplicitObjects extends ImplicitObjects
{
/**
* Gettermethod for the ejb context.
- * @return
+ *
+ * @return the context of the bean
*/
public SessionContext getEJBContext();
/**
* Setter method for the session context.
- * @param theContext
+ *
+ * @param theContext the context of the bean.
*/
public void setEJBContext(SessionContext theContext);
/**
* Setter method for the ejb request.
- * @param theRequest
+ *
+ * @param theRequest for the bean
*/
public void setEJBRequest(EJBRequest theRequest);
/**
* Getter method for the ejb request.
- * @return
+ *
+ * @return the request for the bean
*/
public EJBRequest getEJBRequest();
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestCaller.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestCaller.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestCaller.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestCaller.java Thu Feb 5 12:40:21 2009
@@ -1,4 +1,3 @@
-package org.apache.cactus.internal.server;
/*
* ========================================================================
*
@@ -20,17 +19,21 @@
* ========================================================================
*/
+package org.apache.cactus.internal.server;
+
import org.apache.cactus.internal.AbstractCactusTestCase;
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public class EJBTestCaller extends AbstractEJBTestCaller
{
/**
* A constructor that takes the implicitObjects as a parameter.
- * @param objects
+ *
+ * @param theObjects for the bean
*/
public EJBTestCaller(EJBImplicitObjects theObjects)
{
@@ -39,10 +42,11 @@
/**
* A constructor that takes the instance of the test-case as a parameter.
- * @parameter theTestInstance
+ *
+ * @param theTestInstance to test
+ * @throws Exception if an error occurs
*/
- protected void setTestCaseFields(AbstractCactusTestCase theTestInstance)
- throws Exception
+ protected void setTestCaseFields(AbstractCactusTestCase theTestInstance) throws Exception
{
//Does nothing
}
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestController.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestController.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestController.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/EJBTestController.java Thu Feb 5 12:40:21 2009
@@ -1,4 +1,3 @@
-package org.apache.cactus.internal.server;
/*
* ========================================================================
*
@@ -20,9 +19,12 @@
* ========================================================================
*/
+package org.apache.cactus.internal.server;
+
/**
* Prototype of EJBRedirector for Cactus.
- * @author Siddhartha P. Chandurkar (siddhartha@visioncodified.com)
+ *
+ * @version $Id$
*/
public class EJBTestController extends AbstractEJBTestController
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestCaller.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestCaller.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestCaller.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestCaller.java Thu Feb 5 12:40:21 2009
@@ -50,9 +50,9 @@
/**
* @param theObjects the implicit objects coming from the redirector
*/
- public MessageDrivenBeanTestCaller(MessageDrivenBeanImplicitObjects objects)
+ public MessageDrivenBeanTestCaller(MessageDrivenBeanImplicitObjects theObjects)
{
- super(objects);
+ super(theObjects);
}
/**
@@ -78,18 +78,19 @@
String nameOfQueue = request.getQueueName();
QueueConnectionFactory qcf = ((QueueConnectionFactory)
- ((InitialContext)mdbImplicitObjects.getMessageDrivenBeanContext()).lookup(nameOfQueue));
+ ((InitialContext) mdbImplicitObjects.getMessageDrivenBeanContext()).lookup(nameOfQueue));
Method respondMethod = jmsInstance.getClass().getMethod("getJMSReplyTo", new Class[]{});
- Field requestField = jmsInstance.getClass().getField("request"); //TODO find the appropriate field names here.
+ Field requestField = jmsInstance.getClass().getField("request"); //TODO find the appropriate field names here.
//requestField.set(jmsInstance,
// AbstractHttpServletRequestWrapper.newInstance(request, url));
// Set the response queue field of the test case class
// ---------------------------------------------
- Field responseQueueField = jmsInstance.getClass().getField("jMSReplyTo"); //TODO find the appropriate field names here.
+ //TODO find the appropriate field names here.
+ Field responseQueueField = jmsInstance.getClass().getField("jMSReplyTo");
//responseQueueField.set(jmsInstance,
// mdbImplicitObjects.getHttpServletResponse());
@@ -114,28 +115,40 @@
// sessionField.set(jmsInstance, session);
// }
}
-
+ /**
+ * Empty implementation.
+ */
public void doTest()
{
}
+ /**
+ * Empty implementation.
+ */
public void doGetResults()
{
}
+ /**
+ * Empty implementation.
+ */
public void doRunTest()
{
}
-
+ /**
+ * Empty implementation.
+ */
public void doCreateSession()
{
}
-
+ /**
+ * Empty implementation.
+ */
public void doGetVersion()
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestController.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestController.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestController.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/server/MessageDrivenBeanTestController.java Thu Feb 5 12:40:21 2009
@@ -60,8 +60,8 @@
/**
* This method is supposed to handle the request from the Redirector.
*
- * @param theObjects
- * @throws JMSException
+ * @param theObjects for the request
+ * @throws JMSException in case an error occurs
*/
public void handleRequest(ImplicitObjects theObjects) throws JMSException
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanImplicitObjects.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanImplicitObjects.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanImplicitObjects.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanImplicitObjects.java Thu Feb 5 12:40:21 2009
@@ -29,8 +29,6 @@
/**
* Implicit objects for the Message Driven Bean redirector.
*
- * @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
- *
* @version $Id$
*/
public class MessageDrivenBeanImplicitObjects implements ImplicitObjects
@@ -67,7 +65,7 @@
/**
* Setter for the queue that we are about to post our request to.
*
- * @param requestQueue
+ * @param theRequestQueue parameter
*/
public void setRequestQueue(Queue theRequestQueue)
{
@@ -112,7 +110,7 @@
/**
* Getter method for the request object.
- * @return
+ * @return the jms request
*/
public JmsRequest getRequest()
{
@@ -121,7 +119,7 @@
/**
* Setter method for the jms request object.
- * @param theRequest
+ * @param theRequest parameter
*/
public void setRequest(JmsRequest theRequest)
{
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanRedirector.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanRedirector.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanRedirector.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/spi/server/MessageDrivenBeanRedirector.java Thu Feb 5 12:40:21 2009
@@ -40,8 +40,6 @@
* Generic Message Driven Bean redirector that calls a test method on the
* server side.
*
- * @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
- *
* @since 1.4
*
* @version $Id$
@@ -53,7 +51,15 @@
* The Message context.
*/
private MessageDrivenContext context;
- QueueConnection connection;
+
+ /**
+ * Connection for the MDB.
+ */
+ QueueConnection connection;
+
+ /**
+ * Session of the MDB.
+ */
QueueSession session;
/**
@@ -92,7 +98,7 @@
QueueSession.AUTO_ACKNOWLEDGE);
connection.start();
}
- catch(Exception e)
+ catch (Exception e)
{
throw new EJBException("Failed to initialize MyMDB", e);
}
Modified: jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java?rev=741091&r1=741090&r2=741091&view=diff
==============================================================================
--- jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java (original)
+++ jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java Thu Feb 5 12:40:21 2009
@@ -26,7 +26,6 @@
* Provides access to the Cactus configuration parameters related to the
* JMS Redirector.
*
- * @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
*
* @since 1.4
*
@@ -46,8 +45,8 @@
System.getProperty("cactus.jndi.initialContextFactory");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jndi.initialContextFactory" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jndi.initialContextFactory" + "]");
}
return property;
}
@@ -64,8 +63,8 @@
System.getProperty("cactus.jndi.providerUrl");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jndi.providerUrl" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jndi.providerUrl" + "]");
}
return property;
}
@@ -82,8 +81,8 @@
System.getProperty("cactus.jndi.urlPkgPrefixes");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jndi.urlPkgPrefixes" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jndi.urlPkgPrefixes" + "]");
}
return property;
}
@@ -100,8 +99,8 @@
System.getProperty("cactus.jndi.securityPrincipal");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jndi.securityPrincipal" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jndi.securityPrincipal" + "]");
}
return property;
}
@@ -118,8 +117,8 @@
System.getProperty("cactus.jndi.securityCredentials");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jndi.securityCredentials" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jndi.securityCredentials" + "]");
}
return property;
}
@@ -136,8 +135,8 @@
System.getProperty("cactus.jms.connectionFactoryJndiName");
if (property == null)
{
- throw new ChainedRuntimeException("Missing Cactus property [" +
- "cactus.jms.connectionFactoryJndiName" + "]");
+ throw new ChainedRuntimeException("Missing Cactus property ["
+ + "cactus.jms.connectionFactoryJndiName" + "]");
}
return property;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org