You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Guozhang Wang (JIRA)" <ji...@apache.org> on 2013/12/09 19:38:08 UTC

[jira] [Commented] (KAFKA-1142) Patch review tool should take diff with origin from last divergent point

    [ https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843382#comment-13843382 ] 

Guozhang Wang commented on KAFKA-1142:
--------------------------------------

Instead of doing a git diff with the common ancestor, shall we just force a rebase on the patch before doing the diff?

> Patch review tool should take diff with origin from last divergent point
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-1142
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1142
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Joel Koshy
>            Assignee: Joel Koshy
>         Attachments: KAFKA-1142.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)