You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Geoff Holden (JIRA)" <ji...@apache.org> on 2008/03/11 18:46:35 UTC

[jira] Created: (AMQ-1616) JMS Compliance - Closing a closed connection should not throw an exception

JMS Compliance - Closing a closed connection should not throw an exception
--------------------------------------------------------------------------

                 Key: AMQ-1616
                 URL: https://issues.apache.org/activemq/browse/AMQ-1616
             Project: ActiveMQ
          Issue Type: Bug
    Affects Versions: 5.0.0
         Environment: Ubuntu Linux
            Reporter: Geoff Holden
            Priority: Minor
         Attachments: close_connection.patch

According to the JMS Spec, section 4.3.5, "Closing a closed connection must NOT throw an exception."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1616) JMS Compliance - Closing a closed connection should not throw an exception

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42039#action_42039 ] 

Hiram Chirino commented on AMQ-1616:
------------------------------------

That part of the spec is in conflict with JMS API documentation which states:

that the close() method throws "JMSException - if the JMS provider fails to close the connection due to some internal error. For example, a failure to release resources or to close a socket connection can cause this exception to be thrown."

So I don't think we are in violation of the spec.  If they really did not want an exception to be thrown, they would have not added the "throws JMSException" to the API.



> JMS Compliance - Closing a closed connection should not throw an exception
> --------------------------------------------------------------------------
>
>                 Key: AMQ-1616
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1616
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>         Environment: Ubuntu Linux
>            Reporter: Geoff Holden
>            Priority: Minor
>         Attachments: close_connection.patch
>
>
> According to the JMS Spec, section 4.3.5, "Closing a closed connection must NOT throw an exception."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (AMQ-1616) JMS Compliance - Closing a closed connection should not throw an exception

Posted by "Geoff Holden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Holden reopened AMQ-1616:
-------------------------------


BY my reading of the spec and API documentation, an exception should be thrown in the case of any unexpected error, but it explicitly states that closing a connection that's previously been closed should not throw an exception.

> JMS Compliance - Closing a closed connection should not throw an exception
> --------------------------------------------------------------------------
>
>                 Key: AMQ-1616
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1616
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>         Environment: Ubuntu Linux
>            Reporter: Geoff Holden
>            Priority: Minor
>         Attachments: close_connection.patch
>
>
> According to the JMS Spec, section 4.3.5, "Closing a closed connection must NOT throw an exception."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1616) JMS Compliance - Closing a closed connection should not throw an exception

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-1616.
--------------------------------

    Resolution: Won't Fix

> JMS Compliance - Closing a closed connection should not throw an exception
> --------------------------------------------------------------------------
>
>                 Key: AMQ-1616
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1616
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>         Environment: Ubuntu Linux
>            Reporter: Geoff Holden
>            Priority: Minor
>         Attachments: close_connection.patch
>
>
> According to the JMS Spec, section 4.3.5, "Closing a closed connection must NOT throw an exception."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1616) JMS Compliance - Closing a closed connection should not throw an exception

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-1616.
--------------------------------

    Fix Version/s: 5.1.0
       Resolution: Fixed

Ahh that makes more sense :)  Sorry about that.  A simpler fix committed in rev 645601. 

> JMS Compliance - Closing a closed connection should not throw an exception
> --------------------------------------------------------------------------
>
>                 Key: AMQ-1616
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1616
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>         Environment: Ubuntu Linux
>            Reporter: Geoff Holden
>            Priority: Minor
>             Fix For: 5.1.0
>
>         Attachments: close_connection.patch
>
>
> According to the JMS Spec, section 4.3.5, "Closing a closed connection must NOT throw an exception."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.