[GitHub] [tvm] Hzfengsy commented on a diff in pull request #14693: [TIR] Enhance TVMScript Buffer Slice Access

["Hzfengsy (via GitHub)" <gi...@apache.org>]

Hzfengsy commented on code in PR #14693:
URL: https://github.com/apache/tvm/pull/14693#discussion_r1173645372


##########
python/tvm/tir/stmt.py:
##########
@@ -536,6 +536,12 @@ class BufferRegion(Object, Scriptable):
     def __init__(self, buffer: Buffer, region: List[Range]):
         self.__init_handle_by_constructor__(_ffi_api.BufferRegion, buffer, region)  # type: ignore
 
+    def __eq__(self, other):

Review Comment:
   Not sure if it's safe. I tried doing similar things in Relax operators, but it may influence the behavior of `StructualEqual`, see  https://github.com/apache/tvm/blob/8569b9fe632b9488978bede30e169d457aafd8c9/python/tvm/relax/expr.py#L152



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org