You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/04 20:23:00 UTC

[GitHub] [incubator-druid] pjain1 opened a new pull request #8026: set DRUID_AUTHORIZATION_CHECKED attribute for router endpoints

pjain1 opened a new pull request #8026: set DRUID_AUTHORIZATION_CHECKED attribute for router endpoints
URL: https://github.com/apache/incubator-druid/pull/8026
 
 
   Fixes #6786 
   
   ### Description
   
   Router cannot perform any authorization checks and depends on requests forwarded to other nodes to perform authorization and set `DRUID_AUTHORIZATION_CHECKED` header. It works fine in most cases, however for requests that are not forwarded to other nodes and are not in unsecured path list, this header is not set, thus `PreResponseAuthorizationCheckFilter` throws exception. Example of this would be `/druid/router/v1/brokers` end point on router.
   
   To fix this added a no-op _authorization_ filter for all endpoints on router. Current `UnsecuredResourceFilter` filter actually acts as no-op for both authorization and authentication. So, parameterized it so that caller can choose which checks to bypass. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org