[jira] [Commented] (OAK-822) TypeEditor: Missing validation for mandatory items

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658256#comment-13658256 ] 

Jukka Zitting commented on OAK-822:
-----------------------------------

The validation is actually there, but due to a backwards compatibility issue with Jackrabbit, the validator in the described case would actually ends up choosing the residual undefined multi-valued property definition instead of the named jcr:uuid one. See OAK-713 for related discussion and a proposed solution.

For the specific case of mandatory items I think we could force the validator to never fall back on residual item definitions, which should solve this issue already before we come to a better consensus on what to do in OAK-713.
                
> TypeEditor: Missing validation for mandatory items
> --------------------------------------------------
>
>                 Key: OAK-822
>                 URL: https://issues.apache.org/jira/browse/OAK-822
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>
> Within TypeEditor#leave we check if there are missing mandatory items. 
> However, the validation is currently insufficient as it only checks if
> items with the required names are present.
> for example:
> a referenceable unstructured node that as a multivalued boolean 
> property named "jcr:uuid" would pass the validation even though that 
> property is not the jcr:uuid property defined by "mix:referenceable" 
> but rather a residual property which by coincidence has the same name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira