[GitHub] [daffodil] mbeckerle commented on a change in pull request #772: Clear diagnostics (warnings) on saveParser.

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #772:
URL: https://github.com/apache/daffodil/pull/772#discussion_r824923577



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/SchemaSetRuntimeData.scala
##########
@@ -23,20 +23,20 @@ import org.apache.daffodil.processors.unparsers.Unparser
 import org.apache.daffodil.processors.parsers.Parser
 import org.apache.daffodil.processors.TypeCalculatorCompiler.TypeCalcMap
 
-final class SchemaSetRuntimeData(
-  val parser: Parser,
-  val unparser: Unparser,
+final case class SchemaSetRuntimeData(
+  parser: Parser,
+  unparser: Unparser,
   /*
    * Memory of the compiler's warnings. If we save a processor, it's useful to be able
    * to have these warnings.
    */
-  val diagnostics: Seq[Diagnostic],
-  val elementRuntimeData: ElementRuntimeData,
+  diagnostics: Seq[Diagnostic],
+  elementRuntimeData: ElementRuntimeData,
   /*
    * The original variables determined by the schema compiler.
    */
-  variables: VariableMap,
-  val typeCalculators: TypeCalcMap)
+  variables_ : VariableMap,

Review comment:
       I made this a case class to get the automatic copy method. But that also makes all the args into public values. So the _ suffix is to say "not really for public use". 
   
   I think this is moot however, because I'm going to try the approach SL suggested. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org