[incubator-pinot] branch master updated: Minor fix for star-tree v2 metadata (#3733)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 79ef7f9  Minor fix for star-tree v2 metadata (#3733)
79ef7f9 is described below

commit 79ef7f9fa1df45c3d0d75c3dc274d805447b9dc7
Author: Xiaotian (Jackie) Jiang <17...@users.noreply.github.com>
AuthorDate: Wed Jan 23 09:36:39 2019 -0800

    Minor fix for star-tree v2 metadata (#3733)
    
    Use setProperty() instead of addProperty() for sub-config.
    Calling addProperty() for sub-config will cause list of properties
    written in multiple lines. Changing it to setProperty() can wrap
    the list into one single line, thus enhance readability. Also, it
    can prevent writing the same property multiple times.
    
    E.g.
    Result after addProperty("a", [1, 2]):
    a = 1
    a = 2
    Result after setProperty("a", [1, 2]):
    a = 1,2
---
 .../pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
index 3fed636..2ef02e8 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
@@ -498,11 +498,11 @@ abstract class BaseSingleTreeBuilder implements SingleTreeBuilder {
   }
 
   private void writeMetadata() {
-    _metadataProperties.addProperty(MetadataKey.TOTAL_DOCS, _numDocs);
-    _metadataProperties.addProperty(MetadataKey.DIMENSIONS_SPLIT_ORDER, _dimensionsSplitOrder);
-    _metadataProperties.addProperty(MetadataKey.FUNCTION_COLUMN_PAIRS, _metrics);
-    _metadataProperties.addProperty(MetadataKey.MAX_LEAF_RECORDS, _maxLeafRecords);
-    _metadataProperties.addProperty(MetadataKey.SKIP_STAR_NODE_CREATION_FOR_DIMENSIONS,
+    _metadataProperties.setProperty(MetadataKey.TOTAL_DOCS, _numDocs);
+    _metadataProperties.setProperty(MetadataKey.DIMENSIONS_SPLIT_ORDER, _dimensionsSplitOrder);
+    _metadataProperties.setProperty(MetadataKey.FUNCTION_COLUMN_PAIRS, _metrics);
+    _metadataProperties.setProperty(MetadataKey.MAX_LEAF_RECORDS, _maxLeafRecords);
+    _metadataProperties.setProperty(MetadataKey.SKIP_STAR_NODE_CREATION_FOR_DIMENSIONS,
         _builderConfig.getSkipStarNodeCreationForDimensions());
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org