[GitHub] [helix] pkuwm commented on a change in pull request #1066: Prevent parallel controller pipelines run causing two master replicas

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r456346887



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java
##########
@@ -372,6 +372,12 @@ public void asyncCreate(String path, Object datat, CreateMode mode,
     _rawZkClient.asyncCreate(path, datat, mode, cb);
   }
 
+  @Override
+  public void asyncCreate(String path, Object datat, CreateMode mode,

Review comment:
       @jiajunwang PR updated.
   We decided to keep current existing interfaces as they are. Instead, we use the srcSessionId in message as the expected session id to create message znode.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org