[GitHub] [accumulo] milleruntime commented on a change in pull request #1934: Stop recovery if tablet is being deleted

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1934:
URL: https://github.com/apache/accumulo/pull/1934#discussion_r578319647



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -340,7 +340,7 @@ public Tablet(final TabletServer tabletServer, final KeyExtent extent,
 
     tabletMemory = new TabletMemory(this);
 
-    if (!logEntries.isEmpty()) {
+    if (!logEntries.isEmpty() && !isBeingDeleted()) {

Review comment:
       I can add a comment. 
   
   > Is this change just to avoid attempting WAL recovery on a table being deleted, if such a tablet is being loaded?
   
   Exactly. This is one optimization of least resistance for deletes during a tablet load. I really didn't want to try and short circuit the Tablet loading and risk breaking something.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org