You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/13 08:07:32 UTC

[GitHub] [iceberg] pvary commented on pull request #3879: Core: Remove duplicate Conf() method.

pvary commented on pull request #3879:
URL: https://github.com/apache/iceberg/pull/3879#issuecomment-1011892072


   Since it is `Hadoop`FileIo, I think it is "natural" to expect it to implement `org.apache.hadoop.conf.Configurable`. That would mean that we would want to keep `getConf()`. OTOH in Iceberg `conf()` is the way to access attributes.
   
   I would vote for keeping both, but a comment might be useful to encourage the usage of the `conf()` method. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org