[jira] [Work logged] (ARTEMIS-3604) Async sends could overflow server with messages in openwire

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3604?focusedWorklogId=693826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-693826 ]

ASF GitHub Bot logged work on ARTEMIS-3604:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Dec/21 10:08
            Start Date: 10/Dec/21 10:08
    Worklog Time Spent: 10m 
      Work Description: gtully commented on a change in pull request #3876:
URL: https://github.com/apache/activemq-artemis/pull/3876#discussion_r766539577



##########
File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
##########
@@ -236,6 +238,18 @@ public void removeConnection(ConnectionInfo info, Throwable error) throws Invali
       }
    }
 
+   /*** if set, the OpenWire connection will bypass the tcpReadBuferSize and use this value instead.
+    *   This is by default -1, and it should not be used unless in extreme situations like on a slow storage. */
+   public int getMaxActorSize() {

Review comment:
       this does not make sense to me, a config that should not be used. The intent is to bound the queue and it is matched to the receive buffer size. if it needs to be lower or higher then modify the acceptor receive buffer size. The bounding of the actor stops reading, so at a max the receive buffer size will be pending on the socket and in the broker. Then the client will block on a tcp write. When will it make sense to have more than send buffer pending on the broker? I don't know how to reason about setting a maxActorSize on the protocol manager!
   in terms of a name, it could be actorPendingQueueMaxSizeBytes but that is an aside. Only add that if we know when it should be set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 693826)
    Time Spent: 20m  (was: 10m)

> Async sends could overflow server with messages in openwire
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-3604
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3604
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.20.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)