You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by "Fang Zheng (JIRA)" <ji...@apache.org> on 2018/10/31 22:34:01 UTC

[jira] [Created] (ORC-429) Refactor code in TypeImpl.cc

Fang Zheng created ORC-429:
------------------------------

             Summary: Refactor code in TypeImpl.cc
                 Key: ORC-429
                 URL: https://issues.apache.org/jira/browse/ORC-429
             Project: ORC
          Issue Type: Improvement
            Reporter: Fang Zheng


Propose to make two changes to the code in TypeImpl.cc
 
1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed.

2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. Please see pull request for details.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)