[GitHub] [rocketmq] XiaoyiPeng opened a new issue, #4280: We can make some trivial optimizations to the method 'indexKeyHashMethod' in class 'IndexFile'.

[GitBox <gi...@apache.org>]

XiaoyiPeng opened a new issue, #4280:
URL: https://github.com/apache/rocketmq/issues/4280

   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
       We can make some trivial optimizations to the method 'indexKeyHashMethod' in class 'IndexFile', as shown below: 
    https://github.com/apache/rocketmq/blob/edbea4dabf3e1b3a77cc8351586ffc713561921a/store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java#L148-L154
   
       1.Change the method modifier from public to private.
       2. Remove code from  `Line#151` to `Line#152`
   
   
   2. Please tell us about your environment:
   
      OS: Windows10 
      branch: develop
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] XiaoyiPeng closed issue #4280: We can make some trivial optimizations to the method 'indexKeyHashMethod' in class 'IndexFile'.

[GitBox <gi...@apache.org>]

XiaoyiPeng closed issue #4280: We can make some trivial optimizations to the method 'indexKeyHashMethod' in class 'IndexFile'.
URL: https://github.com/apache/rocketmq/issues/4280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org